Skip to content

Commit a2dc1ea

Browse files
committed
fix: disable upstream "New" badge registrations in MaybeRegisterChromeNewBadges to prevent highlighting of features not surfaced in Dao UI
1 parent 84dc9a8 commit a2dc1ea

1 file changed

Lines changed: 0 additions & 19 deletions

File tree

src/patches/chrome/browser/ui/views/user_education/browser_user_education_service.cc.patch

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -92,22 +92,3 @@ index b7ec475c86..50cc2d6f42 100644
9292
}
9393

9494
// NOTES FOR FEATURE TEAMS:
95-
@@ -2173,6 +2191,10 @@ void MaybeRegisterChromeTutorials(
96-
// longer that necessary just to keep a "New" Badge around.
97-
//
98-
void MaybeRegisterChromeNewBadges(user_education::NewBadgeRegistry& registry) {
99-
+ // Dao: disable all upstream "New" badges. They highlight Chrome features
100-
+ // that Dao does not surface in its UI.
101-
+ return;
102-
+#if 0 // Dao: upstream new-badge registrations disabled below.
103-
if (registry.IsFeatureRegistered(
104-
user_education::features::kNewBadgeTestFeature)) {
105-
return;
106-
@@ -2272,6 +2294,7 @@ registry.RegisterFeature(user_education::NewBadgeSpecification(
107-
"Show the new badge in the system context menu "
108-
"to toggle the horizontal tab strip "
109-
"to be a vertical tab strip")));
110-
+#endif // Dao: upstream new-badge registrations disabled.
111-
}
112-
113-
std::unique_ptr<user_education::FeaturePromoControllerImpl>

0 commit comments

Comments
 (0)