Skip to content
This repository was archived by the owner on Feb 21, 2023. It is now read-only.

Commit 6fbd083

Browse files
committed
test: 优化group.deleteGroupRole的测试用例以覆盖更多的case
1 parent 764b29b commit 6fbd083

1 file changed

Lines changed: 17 additions & 11 deletions

File tree

test/integration/group/group.spec.ts

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -303,21 +303,22 @@ describe('Test "group" service', () => {
303303

304304
test('Test "group.deleteGroupRole"', async () => {
305305
const userId = new Types.ObjectId();
306-
const role = createTestRole('管理员', ['any']);
306+
const role1 = createTestRole('TestRole1', ['permission1', 'permission2']);
307+
const role2 = createTestRole('TestRole2', ['permission1', 'permission2']);
307308
const testGroup = await insertTestData(
308309
createTestGroup(userId, {
309-
roles: [role],
310+
roles: [role1, role2],
310311
})
311312
);
312313

313-
expect(testGroup.roles.length).toBe(1);
314-
expect(testGroup.roles).toMatchObject([role]);
314+
expect(testGroup.roles.length).toBe(2);
315+
expect(testGroup.roles).toMatchObject([role1, role2]);
315316

316317
const res: Group = await broker.call(
317318
'group.deleteGroupRole',
318319
{
319320
groupId: String(testGroup.id),
320-
roleName: '管理员',
321+
roleName: 'TestRole1',
321322
},
322323
{
323324
meta: {
@@ -326,25 +327,30 @@ describe('Test "group" service', () => {
326327
}
327328
);
328329

329-
expect(res.roles.length).toBe(0);
330-
expect(res.roles).toEqual([]);
330+
expect(res.roles.length).toBe(1);
331+
expect(res.roles).toMatchObject([
332+
{
333+
name: 'TestRole2',
334+
permissions: ['permission1', 'permission2'],
335+
},
336+
]);
331337
});
332338

333339
test('Test "group.updateGroupRolePermission"', async () => {
334340
const userId = new Types.ObjectId();
335-
const role = createTestRole('TestRole', ['permission1', 'permission2']);
341+
const role1 = createTestRole('TestRole1', ['permission1', 'permission2']);
336342
const role2 = createTestRole('TestRole2', ['permission1', 'permission2']);
337343
const testGroup = await insertTestData(
338344
createTestGroup(userId, {
339-
roles: [role, role2],
345+
roles: [role1, role2],
340346
})
341347
);
342348

343349
const res: Group = await broker.call(
344350
'group.updateGroupRolePermission',
345351
{
346352
groupId: String(testGroup.id),
347-
roleName: 'TestRole',
353+
roleName: 'TestRole1',
348354
permissions: ['foo'],
349355
},
350356
{
@@ -357,7 +363,7 @@ describe('Test "group" service', () => {
357363
expect(res.roles.length).toBe(2);
358364
expect(res.roles).toMatchObject([
359365
{
360-
name: 'TestRole',
366+
name: 'TestRole1',
361367
permissions: ['foo'],
362368
},
363369
{

0 commit comments

Comments
 (0)