fix: fix sonnet mode will output invalid json problem

Author: moonrailgun

src/server/model/openai.ts

@@ -34,14 +34,16 @@ export function getOpenAIClient() {
   }
 }
 
+export type RequestOpenAIOptions = Omit<
+  ChatCompletionCreateParamsBase,
+  'model' | 'messages' | 'stream'
+>;
+
 export async function requestOpenAI(
   workspaceId: string,
   prompt: string,
   question: string,
-  options: Omit<
-    ChatCompletionCreateParamsBase,
-    'model' | 'messages' | 'stream'
-  > = {},
+  options: RequestOpenAIOptions = {},
   context?: Record<string, string>
 ): Promise<string> {
   if (!env.openai.enable) {

src/server/model/prompt/survey.spec.ts

@@ -28,7 +28,7 @@ describe('buildSurveyClassifyPrompt', () => {
       const { prompt, question } = buildSurveyClassifyPrompt(
         [
           { id: 'fooo', content: 'Hello, World!' },
-          { id: 'bar', content: 'Hello, Tianji!' },
+          { id: 'baar', content: 'Hello, Tianji!' },
         ],
         []
       );
@@ -60,13 +60,14 @@ describe('buildSurveyTranslationPrompt', () => {
   test.runIf(Boolean(process.env.TEST_SURVEY_PROMPT))(
     'test prompt effect',
     {
-      timeout: 30_000,
+      timeout: 60_000,
     },
     async () => {
-      const { prompt } = buildSurveyTranslationPrompt(
+      const { prompt, question } = buildSurveyTranslationPrompt(
         [
           { id: 'fooo', content: 'Hello, World!' },
-          { id: 'bar', content: 'Hello, Tianji!' },
+          { id: 'baar', content: 'Hello, Tianji!' },
+          { id: 'baaz', content: 'Some bad case with "wrap with qutoe"' },
         ],
         'fr-FR'
       );
@@ -80,7 +81,7 @@ describe('buildSurveyTranslationPrompt', () => {
           },
           {
             role: 'user',
-            content: 'Please help me generate data.',
+            content: question,
           },
         ],
         response_format: {

src/server/model/prompt/survey.ts

@@ -160,19 +160,18 @@ export function buildSurveyTranslationPrompt(
   const prompt = `
 You are a translator expert.
 
-Please help me translate those file to '${language}', direct give me json format response, don't be verbose:
-
-${JSON.stringify(
-  data.reduce((prev, curr) => {
-    return {
-      ...prev,
-      [curr.id]: curr.content,
-    };
-  }, {})
-)}
+Please help me translate those file to '${language}', direct give me json format response, strictly follow the following format and only output the following content, no other information. The NSFW format is not suitable for reading. If you need to wrap a line, you must use \n to indicate it. Do not split complete words when wrapping a line, if you need type " in a string, you must use \\"
 `.trim();
 
   return {
     prompt,
+    question: JSON.stringify(
+      data.reduce((prev, curr) => {
+        return {
+          ...prev,
+          [curr.id]: curr.content,
+        };
+      }, {})
+    ),
   };
 }

src/server/model/task.ts

@@ -36,6 +36,7 @@ export async function runTask(
     });
   } catch (err) {
     const meta = { error: String(err), usageTime: Date.now() - start };
+    console.error('run task error:', meta);
     await prisma.workspaceTask.update({
       where: {
         id: task.id,

src/server/mq/worker.ts

@@ -370,7 +370,7 @@ async function runSurveyAITranslationWorker(msg: string) {
 
     let resultJson: Record<string, string> = {};
     for (const group of groups) {
-      const { prompt } = buildSurveyTranslationPrompt(
+      const { prompt, question } = buildSurveyTranslationPrompt(
         group,
         languageStrategy === 'user' ? language : 'en'
       );
@@ -379,14 +379,9 @@ async function runSurveyAITranslationWorker(msg: string) {
         `Process run survey AI translation, group batch ${++inc}/${groups.length}, size: ${group.length}`
       );
 
-      const res = await requestOpenAI(
-        workspaceId,
-        prompt,
-        'Please help me generate data.',
-        {
-          response_format: { type: 'json_object' },
-        }
-      );
+      const res = await requestOpenAI(workspaceId, prompt, question, {
+        response_format: { type: 'json_object' },
+      });
 
       const json = ensureJSONOutput(res);