Skip to content

Init commit - AI validation assist#296

Draft
ao508 wants to merge 7 commits into
mskcc:masterfrom
ao508:dev-mcp-smile
Draft

Init commit - AI validation assist#296
ao508 wants to merge 7 commits into
mskcc:masterfrom
ao508:dev-mcp-smile

Conversation

@ao508
Copy link
Copy Markdown
Collaborator

@ao508 ao508 commented Apr 28, 2026

Description

<Include a summary of the changes. Please also include relevant motivation and context. List any external dependencies that are required for this change, like new environment variables.>

Manual testing checklist

Check off items under the affected features below.

Frontend

Searching & filtering

  • Searching for a single term or multiple terms returns relevant results
  • Searching in PHI mode returns results with PHI columns
  • Filtering columns returns the results matching the filter
  • [Samples page] Filtering by All, WES, and ACCESS/CMO-CH returns the expected results

Downloading

Confirm that these download actions return a TSV file with the expected columns and record count:

  • Clicking "Download as TSV"
  • Searching for some terms then clicking "Download as TSV"
  • Filtering a column then clicking "Download as TSV"
  • Search in PHI mode then clicking "Download as TSV"
  • Clicking the dropdown download option
  • [Samples page -> WES -> Cohort builder] Clicking the "Download New TEMPO Cohort File" (must populate all required fields and have at least one sample selected)
  • Viewing a sample's data diff and clicking "Download as TSV"

AG Grid interactions

  • [Samples page] Editing a cell updates the value as expected
  • [Samples page] Pasting data into the grid works as expected
  • Editing a cell in a non-editable row/column is prevented
  • Column sorting in ascending and descending order works as expected
  • PHI columns are visible only when PHI mode is enabled and search terms are present

Modals and popups

  • [Samples page] Cell changes confirmation modal appears and works as expected
  • [Requests page] Validation errors are displayed in the Record Validation modal
  • [Samples page -> WES -> Cohort builder] Required fields can be populated and selected samples are displayed in the cohort builder modal
  • Warning modals appear when expected and can be dismissed (e.g. PHI warning when first logged in)

Backend

Schema changes

Schema changes in typeDefs.ts are reflected in the following:

  • The queries defined in operations.graphql
  • The GraphQL types that are auto-generated via yarn run codegen
  • When applicable, ensure that newly added fields are searchable (i.e. added to the "searchable fields" list for a given query)

ao508 added 5 commits April 30, 2026 08:27
Signed-off-by: Angelica Ochoa <15623749+ao508@users.noreply.github.com>
Signed-off-by: Angelica Ochoa <15623749+ao508@users.noreply.github.com>
Signed-off-by: Angelica Ochoa <15623749+ao508@users.noreply.github.com>
Signed-off-by: Angelica Ochoa <15623749+ao508@users.noreply.github.com>
…wing validation errors

Signed-off-by: Angelica Ochoa <15623749+ao508@users.noreply.github.com>
ao508 added 2 commits April 30, 2026 11:38
Signed-off-by: Angelica Ochoa <15623749+ao508@users.noreply.github.com>
Signed-off-by: Angelica Ochoa <15623749+ao508@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant