Handle MCP HTTP request failures#285
Open
volkthienpreecha wants to merge 1 commit intomsoedov:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this while looking at issue #196.
This change adds one small request helper for the MCP backend calls. The helper catches HTTP status errors, request failures, and invalid JSON. It returns a small error object instead of letting those cases fall through.
I kept the existing tool names and backend API paths the same.
Although, I'd note I did not run the full suite. This repo imports a lot of runtime dependencies in tests/conftest.py, so I ran the focused MCP test file for this change.
Happy to adjust anything you find necessary.
Cheers,
Volk