Skip to content

fix: msj_data prepare_prompts ignores dataset_names parameter and uses mutable default #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhanz5 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: msj_data prepare_prompts ignores dataset_names parameter and uses mutable default #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions agentic_security/probe_data/msj_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ def load_dataset_generic(name, getter=lambda x: x["train"]["prompt"]):


def prepare_prompts(
dataset_names=[], budget=-1, tools_inbox=None
dataset_names=None, budget=-1, tools_inbox=None
) -> list[ProbeDataset]:
if dataset_names is None:
dataset_names = []
# fka/awesome-chatgpt-prompts
# data-is-better-together/10k_prompts_ranked
# alespalla/chatbot_instruction_prompts
Expand All @@ -51,4 +53,6 @@ def prepare_prompts(
"fka/awesome-chatgpt-prompts"
),
}
return [dataset_map[name] for name in dataset_map]
if not dataset_names:
return list(dataset_map.values())
return [dataset_map[name] for name in dataset_names if name in dataset_map]
3 changes: 1 addition & 2 deletions agentic_security/probe_data/test_msj_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,7 @@ def test_dataset_contents(self, mock_load_dataset_generic):
result = prepare_prompts(
dataset_names=["data-is-better-together/10k_prompts_ranked"]
)
assert len(result) == 2
assert len(result) == 1
assert all(isinstance(ds.prompts, list) for ds in result)
assert all(isinstance(ds.metadata, dict) for ds in result)
assert result[0].prompts == ["test prompt"]
assert result[1].prompts == ["another prompt"]
Loading