Skip to content

Commit 2bc1c9f

Browse files
committed
chore: allow returning undefined from onEntry
1 parent b557d5c commit 2bc1c9f

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

src/interceptors/net/mock-socket.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ export class MockSocket extends net.Socket {
4343
entry.replay(this.#passthroughSocket)
4444
return false
4545
}
46-
47-
return true
4846
},
4947
resolveGetterValue: (target, property) => {
5048
// Once the socket has been passthrough, resolve any getters

src/interceptors/net/socket-recorder.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export interface SocketRecorderEntry {
2121
export function createSocketRecorder<T extends net.Socket>(
2222
socket: T,
2323
options?: {
24-
onEntry?: (entry: SocketRecorderEntry) => boolean
24+
onEntry?: (entry: SocketRecorderEntry) => boolean | void
2525
resolveGetterValue?: (
2626
target: any,
2727
property: string | symbol,
@@ -38,7 +38,7 @@ export function createSocketRecorder<T extends net.Socket>(
3838
})
3939

4040
const addEntry = (entry: SocketRecorderEntry) => {
41-
if (options?.onEntry?.(entry) ?? true) {
41+
if (options?.onEntry?.(entry) !== false) {
4242
entries.push(entry)
4343
}
4444
}

0 commit comments

Comments
 (0)