Skip to content

arrow: Update to 23.0.1#27945

Merged
lazka merged 9 commits into
msys2:masterfrom
raulcd:arrow-23.0.1
Feb 17, 2026
Merged

arrow: Update to 23.0.1#27945
lazka merged 9 commits into
msys2:masterfrom
raulcd:arrow-23.0.1

Conversation

@raulcd
Copy link
Copy Markdown
Contributor

@raulcd raulcd commented Feb 16, 2026

No description provided.

"${MINGW_PACKAGE_PREFIX}-pkgconf")
options=('staticlibs' 'strip' 'emptydirs')
source=("https://github.com/apache/arrow-adbc/archive/refs/tags/apache-arrow-adbc-${pkgver}.tar.gz"
source=("https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/apache-arrow-adbc-${pkgver}/apache-arrow-adbc-${pkgver}.tar.gz"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use the official download URL recommended by ASF not the GitHub one. This is the same type of URL used on Arrow. See more details here:
apache/arrow-adbc#3947

"https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/apache-arrow-adbc-${pkgver}/apache-arrow-adbc-${pkgver}.tar.gz.asc"
"0001-Update-gir-version-with-pkgconfig.patch")
sha256sums=('55e4129a76ead89a868fa9267e8be2ec7fcb7c41ac44a55e70c2d3591fa0b227'
sha256sums=('48b19d70a734e789da99e3c53ebad57389c914b85fdc9c509188e5f50896b07c'
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had to update the sha256sum. It seems to be related to the issue that was raised on the Arrow mailing list about ADBC's GitHub sha having changed and being different than the official one. For more details on the issue see this thread:
https://lists.apache.org/thread/3z30djzt18fogozj1klotxgqmnx12v18

I've downloaded form https://www.apache.org/dyn/closer.lua which should be the download URL used with stable checksum instead of GitHub and I've validated this is the correct one. Pinging other ARROW PMC members FYI: @lidavidm @amoeba

@raulcd
Copy link
Copy Markdown
Contributor Author

raulcd commented Feb 17, 2026

Weird, I've added the signature check for ADBC and it is rejecting @lidavidm signature:

   ==> Verifying source file signatures with gpg...
      apache-arrow-adbc-22.tar.gz ... FAILED (unknown public key 9CBA4EF977CA20B8)
  ==> ERROR: One or more PGP signatures could not be verified!

I've validated this is the signature on the KEYS file (https://dlcdn.apache.org/arrow/KEYS):

pub   rsa4096 2022-12-12 [SC]
      BE7EF45DBAD38E4EECED390E9CBA4EF977CA20B8
uid           [ultimate] David Li (CODE SIGNING KEY) <lidavidm@apache.org>
sig 3        9CBA4EF977CA20B8 2022-12-12  David Li (CODE SIGNING KEY) <lidavidm@apache.org>
sig 3        45127976E1E825D4 2022-12-14  Andrew A Lamb (https://github.com/alamb) <andrew@nerdnetworks.org>
sub   rsa4096 2022-12-12 [E]
sig          9CBA4EF977CA20B8 2022-12-12  David Li (CODE SIGNING KEY) <lidavidm@apache.org>

-----BEGIN PGP PUBLIC KEY BLOCK-----

Maybe I should remove the addition of the .asc file?

Key is valid here:
https://keyserver.ubuntu.com/pks/lookup?search=9CBA4EF977CA20B8&fingerprint=on&op=index

@mmuetzel
Copy link
Copy Markdown
Collaborator

Afaict, you'd need to add a line like the following in the PKGBUILD file:

validpgpkeys=('E7EF45DBAD38E4EECED390E9CBA4EF977CA20B8')  # David Li (CODE SIGNING KEY)

Preferably just above the sha256sums.

@raulcd
Copy link
Copy Markdown
Contributor Author

raulcd commented Feb 17, 2026

Thanks @mmuetzel I've learnt something new :)

@lazka lazka merged commit 89eacac into msys2:master Feb 17, 2026
8 checks passed
@lazka
Copy link
Copy Markdown
Member

lazka commented Feb 17, 2026

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants