Skip to content

r: remove unzip from makedepends#29993

Open
oech3 wants to merge 1 commit into
msys2:masterfrom
oech3:patch-2
Open

r: remove unzip from makedepends#29993
oech3 wants to merge 1 commit into
msys2:masterfrom
oech3:patch-2

Conversation

@oech3

@oech3 oech3 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@ognevny

ognevny commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

cc @jeroen

@oech3
oech3 marked this pull request as ready for review June 15, 2026 09:40
@jeroen

jeroen commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Maybe the installation process does not requires zip anymore and it can be removed alltogether?

@oech3

oech3 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Is it able to use bsdtar or $(command -v bsdunzip||command -v unzip) at upstream?
build() failed without unzip.

@jeroen

jeroen commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

What error do you get without unzip?

@oech3

oech3 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

@jeroen

jeroen commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Ah right extracting the tzinfo db. I think any unzip will do. What is wrong with current unzip ?

@oech3

oech3 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

#29993 (comment) is the log without bsdunzip hack. So current CI is nothing wrong (passing).

@jeroen

jeroen commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

What is the purpose of this PR? Why do we want to remove unzip from makedepends if the build uses unzip? I much prefer to just declare the dependency, rather than add hacks.

@oech3

oech3 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Because unzip is not actively maintained and has many CVEs. I want to remove it from repository in the future.

@jeroen

jeroen commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Many packages and shell scripts require the unzip command. Maybe it would be better to update the libarchive pacakage to add a global copy or wrapper bsdunzip -> unzip and then have the libarchive package declare:

provides=("unzip")
replaces=("unzip")

@oech3

oech3 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Agreed. It is 6 pkg's runtime dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants