Skip to content

Commit 2f6e3bb

Browse files
authored
Fix badly worded error (#64)
1 parent 8fafb0b commit 2f6e3bb

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

internal/check/valid_owner.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ func (v *ValidOwner) validateTeam(ctx context.Context, name string) *validateErr
243243

244244
if !teamHasWritePermission() {
245245
return newValidateError(
246-
"Team %q cannot review PRs on %q as neither it nor any parent team does not have write permissions.",
246+
"Team %q cannot review PRs on %q as neither it nor any parent team has write permissions.",
247247
team, v.orgRepoName)
248248
}
249249

tests/integration/testdata/TestCheckFailures/owners.golden.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
[err] line 15: Team "masters" does not have permissions associated with the repository "codeowners-samples".
2323
[err] line 15: Team "monarchy" does not have permissions associated with the repository "codeowners-samples".
2424
[err] line 15: Team "naturals" does not have permissions associated with the repository "codeowners-samples".
25-
[err] line 15: Team "ninjas" cannot review PRs on "codeowners-samples" as neither it nor any parent team does not have write permissions.
25+
[err] line 15: Team "ninjas" cannot review PRs on "codeowners-samples" as neither it nor any parent team has write permissions.
2626
[err] line 15: Team "outliers" does not have permissions associated with the repository "codeowners-samples".
2727
[err] line 15: Team "peak-performers" does not have permissions associated with the repository "codeowners-samples".
2828
[err] line 15: Team "power" does not have permissions associated with the repository "codeowners-samples".
@@ -35,7 +35,7 @@
3535
[err] line 15: Team "titans" does not have permissions associated with the repository "codeowners-samples".
3636
[err] line 15: Team "tribe" does not have permissions associated with the repository "codeowners-samples".
3737
[err] line 15: Team "united" does not have permissions associated with the repository "codeowners-samples".
38-
[err] line 15: Team "vikings" cannot review PRs on "codeowners-samples" as neither it nor any parent team does not have write permissions.
38+
[err] line 15: Team "vikings" cannot review PRs on "codeowners-samples" as neither it nor any parent team has write permissions.
3939
[err] line 15: Team "warriors" does not have permissions associated with the repository "codeowners-samples".
4040
[err] line 15: Team "wolf-pack" does not have permissions associated with the repository "codeowners-samples".
4141
[err] line 17: Team "not-existing-team" does not exist in organization "gh-codeowners".

0 commit comments

Comments
 (0)