Skip to content

Commit af107cf

Browse files
committed
M3 release
1 parent a7165c6 commit af107cf

5 files changed

Lines changed: 45 additions & 17 deletions

File tree

Config/config.php

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,25 @@
7373
'integrations' => [
7474
'mautic.integration.sqlConditions' => [
7575
'class' => \MauticPlugin\MauticSqlConditionsBundle\Integration\SqlConditionsIntegration::class,
76+
'arguments' => [
77+
'event_dispatcher',
78+
'mautic.helper.cache_storage',
79+
'doctrine.orm.entity_manager',
80+
'session',
81+
'request_stack',
82+
'router',
83+
'translator',
84+
'logger',
85+
'mautic.helper.encryption',
86+
'mautic.lead.model.lead',
87+
'mautic.lead.model.company',
88+
'mautic.helper.paths',
89+
'mautic.core.model.notification',
90+
'mautic.lead.model.field',
91+
'mautic.plugin.model.integration_entity',
92+
'mautic.lead.model.dnc',
93+
'mautic.crontester.helper',
94+
],
7695
],
7796
],
7897
],

EventListener/CampaignConditionSubscriber.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
use Mautic\CampaignBundle\Event\CampaignBuilderEvent;
1616
use Mautic\CampaignBundle\Event\ConditionEvent;
1717
use MauticPlugin\MauticSqlConditionsBundle\Executioner\SqlExecutioner;
18+
use MauticPlugin\MauticSqlConditionsBundle\Form\Type\SqlConditionsCampaignType;
19+
use MauticPlugin\MauticSqlConditionsBundle\Form\Type\SqlListType;
1820
use MauticPlugin\MauticSqlConditionsBundle\SqlConditionsEvents;
1921
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
2022

@@ -60,7 +62,7 @@ public function onCampaignBuild(CampaignBuilderEvent $event)
6062
[
6163
'label' => 'mautic.sqlConditions',
6264
'eventName' => SqlConditionsEvents::ON_CAMPAIGN_CONDITION_TRIGGER,
63-
'formType' => 'sqlconditions_list',
65+
'formType' => SqlConditionsCampaignType::class,
6466
'formTheme' => 'MauticSqlConditionsBundle:FormTheme\SqlConditionsList',
6567
'formTypeOptions' => ['update_select' => 'campaignevent_properties_sql'],
6668

Form/Type/SqlConditionsCampaignType.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
use MauticPlugin\MauticSqlConditionsBundle\Validator\Constraint\UrlDnsConstraint;
1515
use Symfony\Component\Form\AbstractType;
16+
use Symfony\Component\Form\Extension\Core\Type\ButtonType;
1617
use Symfony\Component\Form\FormBuilderInterface;
1718
use Symfony\Component\OptionsResolver\OptionsResolver;
1819
use Symfony\Component\Routing\RouterInterface;
@@ -73,7 +74,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
7374

7475
$builder->add(
7576
'newButton',
76-
'button',
77+
ButtonType::class,
7778
[
7879
'attr' => [
7980
'class' => 'btn btn-primary btn-nospin',
@@ -99,7 +100,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
99100

100101
$builder->add(
101102
'editButton',
102-
'button',
103+
ButtonType::class,
103104
[
104105
'attr' => [
105106
'class' => 'btn btn-primary btn-nospin',
@@ -126,7 +127,7 @@ public function configureOptions(OptionsResolver $resolver)
126127
/**
127128
* @return string
128129
*/
129-
public function getName()
130+
public function getBlockPrefix()
130131
{
131132
return 'sqlconditions_list';
132133
}

Form/Type/SqlConditionsType.php

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,16 @@
1111

1212
namespace MauticPlugin\MauticSqlConditionsBundle\Form\Type;
1313

14+
use Mautic\CategoryBundle\Form\Type\CategoryListType;
15+
use Mautic\CoreBundle\Form\Type\FormButtonsType;
16+
use Mautic\CoreBundle\Form\Type\YesNoButtonGroupType;
1417
use MauticPlugin\MauticSqlConditionsBundle\Validator\Constraint\UrlDnsConstraint;
1518
use Symfony\Component\Form\AbstractType;
19+
use Symfony\Component\Form\Extension\Core\Type\HiddenType;
1620
use Symfony\Component\Form\Extension\Core\Type\TextareaType;
21+
use Symfony\Component\Form\Extension\Core\Type\TextType;
1722
use Symfony\Component\Form\FormBuilderInterface;
23+
use Symfony\Component\OptionsResolver\OptionsResolver;
1824
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
1925
use Symfony\Component\Validator\Constraints\NotBlank;
2026

@@ -29,7 +35,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
2935

3036
$builder->add(
3137
'name',
32-
'text',
38+
TextType::class,
3339
[
3440
'label' => 'mautic.core.name',
3541
'label_attr' => ['class' => 'control-label'],
@@ -59,26 +65,26 @@ public function buildForm(FormBuilderInterface $builder, array $options)
5965

6066
$builder->add(
6167
'category',
62-
'category',
68+
CategoryListType::class,
6369
[
6470
'bundle' => 'plugin:sqlConditions',
6571
]
6672
);
6773

68-
$builder->add('isPublished', 'yesno_button_group');
74+
$builder->add('isPublished', YesNoButtonGroupType::class);
6975

7076

7177
if (!empty($options['update_select'])) {
7278
$builder->add(
7379
'buttons',
74-
'form_buttons',
80+
FormButtonsType::class,
7581
[
7682
'apply_text' => false,
7783
]
7884
);
7985
$builder->add(
8086
'updateSelect',
81-
'hidden',
87+
HiddenType::class,
8288
[
8389
'data' => $options['update_select'],
8490
'mapped' => false,
@@ -87,29 +93,29 @@ public function buildForm(FormBuilderInterface $builder, array $options)
8793
} else {
8894
$builder->add(
8995
'buttons',
90-
'form_buttons'
96+
FormButtonsType::class
9197
);
9298
}
9399
}
94100

95-
/**
96-
* {@inheritdoc}
97-
*/
98-
public function setDefaultOptions(OptionsResolverInterface $resolver)
101+
102+
public function configureOptions(OptionsResolver $resolver)
99103
{
100104
$resolver->setDefaults(
101105
[
102106
'data_class' => 'MauticPlugin\MauticSqlConditionsBundle\Entity\SqlConditions',
103107
]
104108
);
105109
$resolver->setDefined(['update_select']);
110+
106111
}
107112

108113

114+
109115
/**
110116
* @return string
111117
*/
112-
public function getName()
118+
public function getBlockPrefix()
113119
{
114120
return 'sqlConditions';
115121
}

Views/SqlConditions/list.html.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@
9494
?>
9595
</td>
9696
<td>
97-
<a href="<?php echo $view['router']->generate(
97+
<a href="<?php echo $view['router']->url(
9898
'mautic_sqlConditions_action',
9999
['objectAction' => 'edit', 'objectId' => $item->getId()]
100100
); ?>" data-toggle="ajax">
@@ -121,7 +121,7 @@
121121
'page' => $page,
122122
'limit' => $limit,
123123
'menuLinkId' => 'mautic_sqlConditions_event_index',
124-
'baseUrl' => $view['router']->generate('mautic_sqlConditions_index'),
124+
'baseUrl' => $view['router']->url('mautic_sqlConditions_index'),
125125
'sessionVar' => 'badge',
126126
]
127127
); ?>

0 commit comments

Comments
 (0)