bump Rust version to 1.93.1 and bump rustyline to version 18.0.0#3290
Open
abmclin wants to merge 2 commits into
Open
bump Rust version to 1.93.1 and bump rustyline to version 18.0.0#3290abmclin wants to merge 2 commits into
Rust version to 1.93.1 and bump rustyline to version 18.0.0#3290abmclin wants to merge 2 commits into
Conversation
Fixes regression discovered on Linux after upgrading `rustyline` to 17.0.2; `SIGINT` not handled as expected, breaking ability to interrupt nontermination in `scryer`. This was due to a change in `rustyline`'s `SIGINT` behavior since version 16 and corrected in version 18.
Contributor
|
I've tried making a test for this #3299, but it doesn't seem to catch the issue. Let me know if you have any ideas! |
MSRV discussion settled on `1.93.1` to align with upcoming Debian stable releases
abmclin
changed the title
rustyline to version 18.0.0rustyline to version 18.0.0
abmclin
changed the title
rustyline to version 18.0.0Rust version to 1.93.1 and bump rustyline to version 18.0.0
Contributor
Author
|
Per discussion #2784 I have increased Rust version to 1.93.1 and tested on both Windows and Linux and don't see apparent regressions. |
Skgland
approved these changes
May 5, 2026
Contributor
Author
|
@mthom all CI checks have passed, this PR is ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression discovered on Linux after upgrading
rustylineto 17.0.2;SIGINTnot handled as expected, breaking ability to interrupt nontermination inscryer.This was due to a change in
rustyline'sSIGINTbehavior since version 16 and corrected in version 18.Moved over from #3283