add release(Bool) option to process_wait/3#3310
Open
Skgland wants to merge 4 commits into
Open
Conversation
make process_wait/3 release the Process by default
old rust versions didn't print the pid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the behavior of
process_wait/2andprocess_wait/3.The default for
release(Bool)isrelease(true)matching sictus, but the old behavior was that ofrelease(false).The added tests run into #3300 due to the
assertaat Line 184 of the toplevelscryer-prolog/src/toplevel.pl
Lines 179 to 189 in 8dffd72
cc #3308