Skip to content

Add something that shouldn't be merged.#21

Open
mtwebster wants to merge 1 commit into
masterfrom
test-blocker
Open

Add something that shouldn't be merged.#21
mtwebster wants to merge 1 commit into
masterfrom
test-blocker

Conversation

@mtwebster
Copy link
Copy Markdown
Owner

test

@github-actions
Copy link
Copy Markdown

Best-practices scanner

This pull request contains changes flagged as blocking. Findings under the BLOCK section must be addressed before this PR can be merged.

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Most findings
are advisory and do not automatically disqualify a pull request.

This check is not perfect and will not replace a normal review.


Found 1 potential issue(s):

⛔ BLOCK

⛔ gdk_screen

js/ui/osdWindow.js:174

let x = Gdk.Screen.get_default();

Do not use Gdk.Screen in the Cinnamon runtime.
Use Meta.Display (via global.display/ Main.layoutManager for monitor information instead.


Automated pattern check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant