add error handling to delta-notifier#23
Open
nvdk wants to merge 2 commits into
Open
Conversation
the handler makes sure a 400 or 413 is returned on errors, which should make it more clear if things are going wrong
x-m-el
approved these changes
Jun 18, 2025
Member
Author
|
@madnificent , @erikap the error is now sent in json format |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the handler makes sure a 400 is returned on errors, a 413 is returned (and logged!) for delta's which are too large. This should make it more clear if things are going wrong