Skip to content

add error handling to delta-notifier #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvdk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add error handling to delta-notifier #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6ec2b1
add error handling to delta-notifier
nvdk May 15, 2025
e04ee4a
send payload error as json
nvdk Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { app } from 'mu';
import { app, errorHandler } from 'mu';
import services from './config/rules';
import normalizeQuad from './config/normalize-quad';
import bodyParser from 'body-parser';
Expand Down Expand Up @@ -88,6 +88,20 @@ async function informWatchers( changeSets, res, muCallIdTrail, muSessionId ){
} );
}

app.use((err, req, res, next) => {
if (err.type === 'entity.too.large') {
console.warn(`Payload too large for ${req.method} ${req.originalUrl}`);
return res.status(413).json({
errors: [ {title: 'Payload too large'} ]
});
}

// Pass other errors to the default handler
next(err);
});

app.use(errorHandler);

function tripleMatchesSpec( triple, matchSpec ) {
// form of triple is {s, p, o}, same as matchSpec
if( process.env["DEBUG_TRIPLE_MATCHES_SPEC"] )
Expand Down