Skip to content

Feature/robust-healt-check#5

Open
HugaertsDries wants to merge 10 commits into
mu-semtech:masterfrom
HugaertsDries:feature/robust-healt-check
Open

Feature/robust-healt-check#5
HugaertsDries wants to merge 10 commits into
mu-semtech:masterfrom
HugaertsDries:feature/robust-healt-check

Conversation

@HugaertsDries
Copy link
Copy Markdown

@HugaertsDries HugaertsDries commented Jun 7, 2021

Introduced a metric endpoint. This endpoint can be integrated within Prometheus by following along with this gist.

@erikap
Copy link
Copy Markdown
Member

erikap commented Oct 3, 2023

Does the metric endpoint add additional information compared to the info we can retrieve from app-http-logger?

@nvdk
Copy link
Copy Markdown
Member

nvdk commented Oct 4, 2023

There's some overlap, but this does serve a different purpose. The metric endpoint is useful for real-time metric-based monitoring, such as our prometheus stack.
With this endpoint it's possible to:

  • set up a health indicator from docker compose
  • sent out real time alerts if delta's are failing
  • show the metrics in an admin panel in the application (in my opinion the only reason to not output openmetrics directly, which I'd prefer)

none of which are possible with app http logger

The App http logger empowers analysis and search capabilities of http traffic and a such could give you similar metrics, but more in an after the fact manner.

FYI I'm reworking this PR basing myself on #17 . I'm leaning towards directly exposing metrics in the openmetrics standard vs json though, since I see little value in using a non standard json format for the metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants