Feature/robust-healt-check#5
Open
HugaertsDries wants to merge 10 commits into
Open
Conversation
…not. Updated endpoint to /metric
Member
|
Does the metric endpoint add additional information compared to the info we can retrieve from app-http-logger? |
Member
|
There's some overlap, but this does serve a different purpose. The metric endpoint is useful for real-time metric-based monitoring, such as our prometheus stack.
none of which are possible with app http logger The App http logger empowers analysis and search capabilities of http traffic and a such could give you similar metrics, but more in an after the fact manner. FYI I'm reworking this PR basing myself on #17 . I'm leaning towards directly exposing metrics in the openmetrics standard vs json though, since I see little value in using a non standard json format for the metrics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a metric endpoint. This endpoint can be integrated within Prometheus by following along with this gist.