Fix Issue #3: implement true radix-4 FFT (DIT)#7
Open
noro-ovo wants to merge 1 commit intomuditbhargava66:mainfrom
Open
Fix Issue #3: implement true radix-4 FFT (DIT)#7noro-ovo wants to merge 1 commit intomuditbhargava66:mainfrom
noro-ovo wants to merge 1 commit intomuditbhargava66:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #3 by replacing the current "radix-4" implementation (which is actually radix-2) with a true radix-4 Decimation-in-Time (DIT) FFT.
The previous implementation explicitly used radix-2 butterflies while exposing a radix-4 interface. This PR introduces:
The implementation is now consistent with radix-4 theory and exhibits the expected performance behavior.
Type of Change
Testing
Accuracy
Comparison with radix-2 FFT:
Performance Impact
Benchmarks (FFT execution only, excluding plan construction):
Notes
Implementation Notes
Operation Count (Implementation-Level)
Unlike theoretical counts, this implementation includes:
The code reflects actual execution cost rather than only textbook formulas.
Checklist