Skip to content

Commit 2dade4a

Browse files
localai-botmudler
andauthored
fix(model-artifacts): gate inferred artifact materialization by backend (#10910)
The managed-artifact materializer stages a HuggingFace snapshot into a directory (.artifacts/huggingface/<key>/snapshot/). That is the right load target for directory-consuming backends (transformers, vLLM, diffusers, ...), but PrimaryArtifactSpec inferred a managed artifact from ANY HuggingFace-shaped model reference regardless of backend. A single-file backend such as llama.cpp or whisper was therefore handed the snapshot directory instead of the weight file and failed to load it. The /import-model importer already guards this with a backend allow-list (managedArtifactBackends), but the loader-side inference did not. Move the allow-list into core/config as IsManagedArtifactBackend and apply it in PrimaryArtifactSpec: only directory-consuming backends may have an artifact inferred from a bare reference; every other backend stays on the legacy download-to-file path. An explicit artifacts: block still bypasses the gate, where single-file snapshot resolution handles the load path. The importer now shares the same predicate, so both paths agree on which backends auto-materialize. Assisted-by: Claude:opus-4.8 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
1 parent c0a20d6 commit 2dade4a

3 files changed

Lines changed: 83 additions & 8 deletions

File tree

core/config/model_artifact_inference.go

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,29 @@ import (
99
"github.com/mudler/LocalAI/pkg/modelartifacts"
1010
)
1111

12+
// managedArtifactBackends is the set of backends that load a model from a
13+
// snapshot *directory* (a HuggingFace repo consumed as a folder of weights,
14+
// config, and tokenizer files). Only these backends may have a managed
15+
// artifact *inferred* from a bare model reference: single-file backends such
16+
// as llama.cpp or whisper would otherwise be handed the snapshot directory
17+
// instead of the weight file and fail to load it. The importer relies on the
18+
// same gate, so both paths agree on which backends auto-materialize.
19+
var managedArtifactBackends = map[string]struct{}{
20+
"transformers": {}, "huggingface-embeddings": {}, "sentencetransformers": {},
21+
"transformers-musicgen": {}, "mamba": {}, "diffusers": {}, "qwen-asr": {},
22+
"fish-speech": {}, "nemo": {}, "voxcpm": {}, "qwen-tts": {},
23+
"liquid-audio": {}, "vllm": {}, "vllm-omni": {}, "sglang": {},
24+
}
25+
26+
// IsManagedArtifactBackend reports whether backend consumes a model as a
27+
// snapshot directory and is therefore eligible for inferred artifact
28+
// materialization. An explicit artifacts: block bypasses this gate; single-file
29+
// resolution handles the load path for single-file backends in that case.
30+
func IsManagedArtifactBackend(backend string) bool {
31+
_, ok := managedArtifactBackends[backend]
32+
return ok
33+
}
34+
1235
// PrimaryArtifactSpec returns the managed primary artifact to materialize for
1336
// this config. The boolean return is false when the config should stay on the
1437
// legacy path.
@@ -24,6 +47,12 @@ func (c ModelConfig) PrimaryArtifactSpec(modelsPath string) (modelartifacts.Spec
2447
if len(c.DownloadFiles) > 0 {
2548
return modelartifacts.Spec{}, false, false, nil
2649
}
50+
// Only directory-consuming backends may have an artifact inferred from a
51+
// bare reference; single-file backends stay on the legacy download-to-file
52+
// path so the backend receives the weight file itself, not its directory.
53+
if !IsManagedArtifactBackend(c.Backend) {
54+
return modelartifacts.Spec{}, false, false, nil
55+
}
2756

2857
if modelsPath != "" {
2958
for _, candidate := range []string{
Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
package config_test
2+
3+
import (
4+
. "github.com/onsi/ginkgo/v2"
5+
. "github.com/onsi/gomega"
6+
"gopkg.in/yaml.v3"
7+
8+
"github.com/mudler/LocalAI/core/config"
9+
)
10+
11+
var _ = Describe("PrimaryArtifactSpec backend gating", func() {
12+
parse := func(doc string) config.ModelConfig {
13+
var c config.ModelConfig
14+
Expect(yaml.Unmarshal([]byte(doc), &c)).To(Succeed())
15+
return c
16+
}
17+
18+
It("does not infer a managed artifact for a single-file backend", func() {
19+
// llama.cpp consumes a single GGUF file, not a snapshot directory.
20+
// A bare HuggingFace file reference must stay on the legacy
21+
// download-to-file path so the backend receives the file itself.
22+
c := parse("backend: llama-cpp\nparameters: {model: huggingface://owner/repo/model.gguf}\n")
23+
_, inferred, managed, err := c.PrimaryArtifactSpec("/models")
24+
Expect(err).NotTo(HaveOccurred())
25+
Expect(managed).To(BeFalse())
26+
Expect(inferred).To(BeFalse())
27+
})
28+
29+
It("does not infer a managed artifact for a bare repo on a single-file backend", func() {
30+
c := parse("backend: llama-cpp\nparameters: {model: owner/repo}\n")
31+
_, _, managed, err := c.PrimaryArtifactSpec("/models")
32+
Expect(err).NotTo(HaveOccurred())
33+
Expect(managed).To(BeFalse())
34+
})
35+
36+
It("infers a managed artifact for a directory-consuming backend", func() {
37+
c := parse("backend: transformers\nparameters: {model: huggingface://owner/repo/model.safetensors}\n")
38+
spec, inferred, managed, err := c.PrimaryArtifactSpec("/models")
39+
Expect(err).NotTo(HaveOccurred())
40+
Expect(managed).To(BeTrue())
41+
Expect(inferred).To(BeTrue())
42+
Expect(spec.Source.Repo).To(Equal("owner/repo"))
43+
})
44+
45+
It("keeps explicit artifacts managed even on a single-file backend", func() {
46+
// An explicitly declared artifacts: block is a deliberate choice;
47+
// single-file resolution (PrimaryFile) handles the load path.
48+
c := parse("backend: llama-cpp\nartifacts:\n - source: {type: huggingface, repo: owner/repo}\nparameters: {model: owner/repo}\n")
49+
_, _, managed, err := c.PrimaryArtifactSpec("/models")
50+
Expect(err).NotTo(HaveOccurred())
51+
Expect(managed).To(BeTrue())
52+
})
53+
})

core/gallery/importers/helpers.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,6 @@ import (
1212
"gopkg.in/yaml.v3"
1313
)
1414

15-
var managedArtifactBackends = map[string]struct{}{
16-
"transformers": {}, "huggingface-embeddings": {}, "sentencetransformers": {},
17-
"transformers-musicgen": {}, "mamba": {}, "diffusers": {}, "qwen-asr": {},
18-
"fish-speech": {}, "nemo": {}, "voxcpm": {}, "qwen-tts": {},
19-
"liquid-audio": {}, "vllm": {}, "vllm-omni": {}, "sglang": {},
20-
}
21-
2215
// AttachPrimaryArtifact adds the controller-managed source only when the
2316
// importer selected the same repository and a migrated backend.
2417
func AttachPrimaryArtifact(model gallery.ModelConfig, details Details) (gallery.ModelConfig, error) {
@@ -29,7 +22,7 @@ func AttachPrimaryArtifact(model gallery.ModelConfig, details Details) (gallery.
2922
if err := yaml.Unmarshal([]byte(model.ConfigFile), &cfg); err != nil {
3023
return gallery.ModelConfig{}, err
3124
}
32-
if _, supported := managedArtifactBackends[cfg.Backend]; !supported {
25+
if !config.IsManagedArtifactBackend(cfg.Backend) {
3326
return model, nil
3427
}
3528
if len(cfg.Artifacts) != 0 || cfg.Model != details.HuggingFace.ModelID {

0 commit comments

Comments
 (0)