feat(valkey-store): gate Load on NamespacePrefix to refuse autoload probing Mirror local-store's pattern: reject model names without store.NamespacePrefix so the model loader's greedy autoload probe cannot bind an arbitrary model name to the vector store backend (the #9287 failure mode). Also adds unit tests for the gate covering: prefixed namespace, prefix alone, unprefixed model name, empty model, and nil opts.

Signed-off-by: Daria Korenieva <daric2612@gmail.com>

Author: daric93

backend/go/valkey-store/store.go

@@ -113,17 +113,26 @@ func newWithClient(client valkey.Client, cfg Config, namespace string) *ValkeySt
 // identifier (one process per (backend, model) tuple upstream), so we derive
 // an isolated key prefix and index name from it, and opts.Options carries the
 // per-store connection/index configuration.
+//
+// The NamespacePrefix gate mirrors local-store: core's StoreBackend always
+// sends the model name with store.NamespacePrefix; anything else is the model
+// loader's greedy autoload probing with a real model name, which must be
+// refused or the LLM binds to the vector store (the #9287 failure mode).
 func (s *ValkeyStore) Load(opts *pb.ModelOptions) error {
+	if opts == nil {
+		return fmt.Errorf("valkey-store: refusing to load: nil model options (expected %q prefix)", store.NamespacePrefix)
+	}
+	if !strings.HasPrefix(opts.GetModel(), store.NamespacePrefix) {
+		return fmt.Errorf("valkey-store: refusing to load %q: not a store namespace (expected %q prefix)", opts.GetModel(), store.NamespacePrefix)
+	}
+
 	cfg, err := loadConfig(opts)
 	if err != nil {
 		return err
 	}
 	s.cfg = cfg
 
-	namespace := ""
-	if opts != nil {
-		namespace = opts.Model
-	}
+	namespace := opts.Model
 	s.prefix = keyPrefix(namespace)
 	s.indexName = indexName(namespace)
 

backend/go/valkey-store/store_test.go

@@ -113,6 +113,41 @@ var _ = Describe("loadConfig", func() {
 	})
 })
 
+var _ = Describe("Load namespace gate", func() {
+	It("accepts prefixed store namespaces", func() {
+		s := NewValkeyStore()
+		// Load will fail at the Valkey connect step (no server), but only after
+		// passing the namespace gate. A network error is acceptable here — it
+		// means the prefix check passed.
+		err := s.Load(&pb.ModelOptions{Model: store.NamespacePrefix + "any-namespace", Options: []string{"addr:localhost:1"}})
+		Expect(err).NotTo(MatchError(ContainSubstring("not a store namespace")))
+	})
+
+	It("accepts the prefix alone (default store)", func() {
+		s := NewValkeyStore()
+		err := s.Load(&pb.ModelOptions{Model: store.NamespacePrefix, Options: []string{"addr:localhost:1"}})
+		Expect(err).NotTo(MatchError(ContainSubstring("not a store namespace")))
+	})
+
+	It("refuses model names without the namespace prefix", func() {
+		s := NewValkeyStore()
+		err := s.Load(&pb.ModelOptions{Model: "some-llm.gguf"})
+		Expect(err).To(MatchError(ContainSubstring("not a store namespace")))
+	})
+
+	It("refuses an empty model name", func() {
+		s := NewValkeyStore()
+		err := s.Load(&pb.ModelOptions{})
+		Expect(err).To(MatchError(ContainSubstring("not a store namespace")))
+	})
+
+	It("refuses nil opts", func() {
+		s := NewValkeyStore()
+		err := s.Load(nil)
+		Expect(err).To(HaveOccurred())
+	})
+})
+
 var _ = Describe("StoresSet", func() {
 	It("rejects empty input", func() {
 		s, _ := newMockStore(testCfg())