chore: apply defaults also to models installed via gallery

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

Author: mudler

core/config/inference_defaults.go

@@ -67,15 +67,27 @@ func MatchModelFamily(modelID string) map[string]float64 {
 	return nil
 }
 
-// ApplyInferenceDefaults sets recommended inference parameters on cfg based on modelID.
+// ApplyInferenceDefaults sets recommended inference parameters on cfg based on modelIDs.
+// Tries each modelID in order; the first match wins.
 // Only fills in parameters that are not already set (nil pointers or zero values).
-func ApplyInferenceDefaults(cfg *ModelConfig, modelID string) {
-	family := MatchModelFamily(modelID)
+func ApplyInferenceDefaults(cfg *ModelConfig, modelIDs ...string) {
+	var family map[string]float64
+	var matchedID string
+	for _, id := range modelIDs {
+		if id == "" {
+			continue
+		}
+		if f := MatchModelFamily(id); f != nil {
+			family = f
+			matchedID = id
+			break
+		}
+	}
 	if family == nil {
 		return
 	}
 
-	xlog.Debug("[inference_defaults] applying defaults for model", "modelID", modelID, "family", family)
+	xlog.Debug("[inference_defaults] applying defaults for model", "modelID", matchedID, "family", family)
 
 	if cfg.Temperature == nil {
 		if v, ok := family["temperature"]; ok {

core/config/model_config.go

@@ -375,6 +375,11 @@ func (cfg *ModelConfig) SetDefaults(opts ...ConfigLoaderOption) {
 	threads := lo.threads
 	f16 := lo.f16
 	debug := lo.debug
+
+	// Apply model-family-specific inference defaults before generic fallbacks.
+	// This ensures gallery-installed and runtime-loaded models get optimal parameters.
+	ApplyInferenceDefaults(cfg, cfg.Name, cfg.Model)
+
 	// https://github.com/ggerganov/llama.cpp/blob/75cd4c77292034ecec587ecb401366f57338f7c0/common/sampling.h#L22
 	defaultTopP := 0.95
 	defaultTopK := 40

core/gallery/models.go

@@ -264,6 +264,15 @@ func InstallModel(ctx context.Context, systemState *system.SystemState, nameOver
 			return nil, fmt.Errorf("failed to unmarshal updated config YAML: %v", err)
 		}
 
+		// Apply model-family-specific inference defaults so they are persisted in the config YAML.
+		lconfig.ApplyInferenceDefaults(&modelConfig, name, modelConfig.Model)
+
+		// Re-marshal to include any inference defaults that were applied.
+		updatedConfigYAML, err = yaml.Marshal(modelConfig)
+		if err != nil {
+			return nil, fmt.Errorf("failed to marshal config with inference defaults: %v", err)
+		}
+
 		if valid, err := modelConfig.Validate(); !valid {
 			return nil, fmt.Errorf("failed to validate updated config YAML: %v", err)
 		}