Skip to content

Commit c66c41e

Browse files
authored
fix(ci): wire AMDGPU_TARGETS through backend build workflow (#9445)
Commit 8839a71 exposed AMDGPU_TARGETS as an ARG/ENV in Dockerfile.llama-cpp so GPU targets could be overridden, but never wired the value through the CI workflow inputs. Without it, Docker receives AMDGPU_TARGETS="" which overrides the Makefile's ?= default, causing all hipblas builds to compile only for gfx906 regardless of the target list in the Makefile. Add amdgpu-targets as a workflow_call input with the same default list as the Makefile, and pass it as AMDGPU_TARGETS in the build-args of both the push and PR build steps. Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Russell Sim <rsl@simopolis.xyz>
1 parent 02bb715 commit c66c41e

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

.github/workflows/backend.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ jobs:
3030
skip-drivers: ${{ matrix.skip-drivers }}
3131
context: ${{ matrix.context }}
3232
ubuntu-version: ${{ matrix.ubuntu-version }}
33+
amdgpu-targets: ${{ matrix.amdgpu-targets }}
3334
secrets:
3435
dockerUsername: ${{ secrets.DOCKERHUB_USERNAME }}
3536
dockerPassword: ${{ secrets.DOCKERHUB_PASSWORD }}

.github/workflows/backend_build.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,11 @@ on:
5858
required: false
5959
default: '2204'
6060
type: string
61+
amdgpu-targets:
62+
description: 'AMD GPU targets for ROCm/HIP builds'
63+
required: false
64+
default: 'gfx908,gfx90a,gfx942,gfx950,gfx1030,gfx1100,gfx1101,gfx1102,gfx1151,gfx1200,gfx1201'
65+
type: string
6166
secrets:
6267
dockerUsername:
6368
required: false
@@ -214,6 +219,7 @@ jobs:
214219
BASE_IMAGE=${{ inputs.base-image }}
215220
BACKEND=${{ inputs.backend }}
216221
UBUNTU_VERSION=${{ inputs.ubuntu-version }}
222+
AMDGPU_TARGETS=${{ inputs.amdgpu-targets }}
217223
context: ${{ inputs.context }}
218224
file: ${{ inputs.dockerfile }}
219225
cache-from: type=gha
@@ -235,6 +241,7 @@ jobs:
235241
BASE_IMAGE=${{ inputs.base-image }}
236242
BACKEND=${{ inputs.backend }}
237243
UBUNTU_VERSION=${{ inputs.ubuntu-version }}
244+
AMDGPU_TARGETS=${{ inputs.amdgpu-targets }}
238245
context: ${{ inputs.context }}
239246
file: ${{ inputs.dockerfile }}
240247
cache-from: type=gha

0 commit comments

Comments
 (0)