Skip to content

Commit d765a40

Browse files
committed
chore: bump go-processmanager to pick up the concurrent-Run fix
Picks up mudler/go-processmanager#7, which closes the check-then-act window in Run's "already started" guard. Concurrent Run calls on one handle could each observe a nil p.proc, each start a process and each launch a monitor goroutine; every monitor does `defer close(p.done)` against a channel created once in New, so the second monitor to see its process exit panicked on close of a closed channel. The same window raced on p.proc itself. LocalAI does not hit this today: the only New/Run pair (pkg/model/process.go:178-191) runs a freshly created handle, and core/services/worker/supervisor.go only ever calls Stop on handles it holds. The bump is defensive, and keeps the dependency from drifting further behind a fix in the process lifecycle we rely on. No exported signature changes upstream; ErrProcessAlreadyRun is additive and keeps the historical "command already started" prefix, so any caller matching on that text is unaffected. Nothing in this repo matches it. Verified: go build ./core/... ./pkg/... clean; go vet clean; go test -race ./pkg/model/ ./core/services/worker/ both ok. Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Assisted-by: Claude Code:claude-opus-4-8[1m] [Read] [Bash] [Edit]
1 parent 0cdd781 commit d765a40

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ require (
3838
github.com/modelcontextprotocol/go-sdk v1.5.0
3939
github.com/mudler/cogito v0.10.1-0.20260609212329-bf4010d31047
4040
github.com/mudler/edgevpn v0.34.0
41-
github.com/mudler/go-processmanager v0.1.2-0.20260719202549-a94e2b7e5f4f
41+
github.com/mudler/go-processmanager v0.1.2-0.20260720195933-3d64f5c974fc
4242
github.com/mudler/memory v0.0.0-20260406210934-424c1ecf2cf8
4343
github.com/mudler/xlog v0.0.6
4444
github.com/nats-io/jwt/v2 v2.7.4
@@ -399,7 +399,7 @@ require (
399399
github.com/ipfs/go-log/v2 v2.9.2 // indirect
400400
github.com/ipld/go-ipld-prime v0.23.0 // indirect
401401
github.com/jackpal/go-nat-pmp v1.0.2 // indirect
402-
github.com/jaypipes/pcidb v1.1.1 // indirect
402+
github.com/jaypipes/pcidb v1.1.1
403403
github.com/jbenet/go-temp-err-catcher v0.1.0 // indirect
404404
github.com/klauspost/compress v1.18.6
405405
github.com/klauspost/pgzip v1.2.6 // indirect

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -974,8 +974,8 @@ github.com/mudler/edgevpn v0.34.0 h1:qDrD/rCPFY/FdURbXudIZWihVKY4VOX3nMn3CcbeQEU
974974
github.com/mudler/edgevpn v0.34.0/go.mod h1:yki7uMi5LR9gSMrw8PdPieuxsrk8BLV2Ui7VBEmbbIA=
975975
github.com/mudler/go-piper v0.0.0-20241023091659-2494246fd9fc h1:RxwneJl1VgvikiX28EkpdAyL4yQVnJMrbquKospjHyA=
976976
github.com/mudler/go-piper v0.0.0-20241023091659-2494246fd9fc/go.mod h1:O7SwdSWMilAWhBZMK9N9Y/oBDyMMzshE3ju8Xkexwig=
977-
github.com/mudler/go-processmanager v0.1.2-0.20260719202549-a94e2b7e5f4f h1:td22tuommnMukfgj92yAzKhkQOQ/V+uWbyzRtPWlLbw=
978-
github.com/mudler/go-processmanager v0.1.2-0.20260719202549-a94e2b7e5f4f/go.mod h1:h6kmHUZeafr+k5hRYpGLMzJFH4hItHffgpRo2QIkP+o=
977+
github.com/mudler/go-processmanager v0.1.2-0.20260720195933-3d64f5c974fc h1:NEFmd7+JoImN5dZI81/vcBRjtMg+GfEa7nEjQ029hd0=
978+
github.com/mudler/go-processmanager v0.1.2-0.20260720195933-3d64f5c974fc/go.mod h1:h6kmHUZeafr+k5hRYpGLMzJFH4hItHffgpRo2QIkP+o=
979979
github.com/mudler/localrecall v0.6.3 h1:uXOrP9JmetzxgVKzSrawviyBHZfAcvPBBIrvVUdZjDA=
980980
github.com/mudler/localrecall v0.6.3/go.mod h1:28k5n19raUrkuwXkacdNsBlj8yuSnGhpT16tu+2+4dU=
981981
github.com/mudler/memory v0.0.0-20260406210934-424c1ecf2cf8 h1:Ry8RiWy8fZ6Ff4E7dPmjRsBrnHOnPeOOj2LhCgyjQu0=

0 commit comments

Comments
 (0)