fix(mcp): narrow scheduling dto

Assisted-by: Hephaestus:openai/gpt-5.5 [opencode]
Signed-off-by: Owen Adirah <owenadira@gmail.com>

Author: owezzy

pkg/mcp/localaitools/dto.go

@@ -1,10 +1,6 @@
 package localaitools
 
-import (
-	"time"
-
-	"github.com/mudler/LocalAI/core/services/voiceprofile"
-)
+import "github.com/mudler/LocalAI/core/services/voiceprofile"
 
 // DTOs for the LocalAIClient interface. Where the same shape already exists
 // elsewhere (config.Gallery, gallery.Metadata, schema.KnownBackend,
@@ -119,25 +115,19 @@ type SetNodeVRAMBudgetRequest struct {
 	Budget string `json:"budget,omitempty" jsonschema:"VRAM allocation cap as a percentage (e.g. 80%) or absolute amount (e.g. 12GB). Empty string clears the override."`
 }
 
-// ModelSchedulingConfig is the REST/MCP wire shape for one per-model
-// distributed scheduling rule. Keep this DTO explicit instead of aliasing the
-// node-registry model so MCP contracts remain owned by localaitools while still
-// matching /api/nodes/scheduling JSON.
+// ModelSchedulingConfig is the MCP wire shape for one per-model distributed
+// scheduling rule. Keep this DTO explicit instead of aliasing the node-registry
+// model so the MCP contract only exposes operator-facing scheduling fields.
 type ModelSchedulingConfig struct {
-	ID                  string     `json:"id"`
-	ModelName           string     `json:"model_name"`
-	NodeSelector        string     `json:"node_selector,omitempty"`
-	MinReplicas         int        `json:"min_replicas"`
-	MaxReplicas         int        `json:"max_replicas"`
-	SpreadAll           bool       `json:"spread_all,omitempty"`
-	RoutePolicy         string     `json:"route_policy,omitempty"`
-	BalanceAbsThreshold int        `json:"balance_abs_threshold,omitempty"`
-	BalanceRelThreshold float64    `json:"balance_rel_threshold,omitempty"`
-	MinPrefixMatch      float64    `json:"min_prefix_match,omitempty"`
-	UnsatisfiableUntil  *time.Time `json:"unsatisfiable_until,omitempty"`
-	UnsatisfiableTicks  int        `json:"unsatisfiable_ticks"`
-	CreatedAt           time.Time  `json:"created_at"`
-	UpdatedAt           time.Time  `json:"updated_at"`
+	ModelName           string  `json:"model_name"`
+	NodeSelector        string  `json:"node_selector,omitempty"`
+	MinReplicas         int     `json:"min_replicas"`
+	MaxReplicas         int     `json:"max_replicas"`
+	SpreadAll           bool    `json:"spread_all,omitempty"`
+	RoutePolicy         string  `json:"route_policy,omitempty"`
+	BalanceAbsThreshold int     `json:"balance_abs_threshold,omitempty"`
+	BalanceRelThreshold float64 `json:"balance_rel_threshold,omitempty"`
+	MinPrefixMatch      float64 `json:"min_prefix_match,omitempty"`
 }
 
 // SetSchedulingRequest is the input for set_scheduling. It mirrors

pkg/mcp/localaitools/httpapi/client_test.go

@@ -87,7 +87,16 @@ func fakeLocalAI() *httptest.Server {
 	mux.HandleFunc("/api/nodes/scheduling", func(w http.ResponseWriter, r *http.Request) {
 		switch r.Method {
 		case http.MethodGet:
-			_ = json.NewEncoder(w).Encode([]map[string]any{{"model_name": "qwen", "min_replicas": 1, "max_replicas": 2}})
+			_ = json.NewEncoder(w).Encode([]map[string]any{{
+				"id":                  "sched-1",
+				"model_name":          "qwen",
+				"min_replicas":        1,
+				"max_replicas":        2,
+				"unsatisfiable_ticks": 1,
+				"unsatisfiable_until": "2026-01-01T00:00:00Z",
+				"created_at":          "2026-01-01T00:00:00Z",
+				"updated_at":          "2026-01-01T00:00:00Z",
+			}})
 		case http.MethodPost:
 			var body map[string]any
 			if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
@@ -233,6 +242,13 @@ var _ = Describe("httpapi.Client against the LocalAI admin REST surface", func()
 			Expect(out).To(HaveLen(1))
 			Expect(out[0].ModelName).To(Equal("qwen"))
 			Expect(out[0].MinReplicas).To(Equal(1))
+			Expect(schedulingJSONKeys(&out[0])).ToNot(Or(
+				HaveKey("id"),
+				HaveKey("unsatisfiable_until"),
+				HaveKey("unsatisfiable_ticks"),
+				HaveKey("created_at"),
+				HaveKey("updated_at"),
+			))
 		})
 
 		It("gets one scheduling config", func() {
@@ -245,7 +261,6 @@ var _ = Describe("httpapi.Client against the LocalAI admin REST surface", func()
 		It("sets a scheduling config", func() {
 			out, err := c.SetScheduling(ctx, localaitools.SetSchedulingRequest{ModelName: "qwen", MinReplicas: 1, MaxReplicas: 2})
 			Expect(err).ToNot(HaveOccurred())
-			Expect(out.ID).To(Equal("sched-1"))
 			Expect(out.ModelName).To(Equal("qwen"))
 			Expect(out.MaxReplicas).To(Equal(2))
 		})
@@ -256,6 +271,14 @@ var _ = Describe("httpapi.Client against the LocalAI admin REST surface", func()
 	})
 })
 
+func schedulingJSONKeys(config *localaitools.ModelSchedulingConfig) map[string]any {
+	var out map[string]any
+	b, err := json.Marshal(config)
+	Expect(err).ToNot(HaveOccurred())
+	Expect(json.Unmarshal(b, &out)).To(Succeed())
+	return out
+}
+
 var _ = Describe("Model aliases", func() {
 	Describe("ListAliases", func() {
 		It("passes the GET /api/aliases payload through unchanged", func() {

pkg/mcp/localaitools/inproc/client_test.go

@@ -2,6 +2,7 @@ package inproc
 
 import (
 	"context"
+	"encoding/json"
 	"errors"
 	"os"
 	"path/filepath"
@@ -165,6 +166,13 @@ var _ = Describe("inproc.Client model scheduling", func() {
 		Expect(created.NodeSelector).To(Equal(`{"gpu":"nvidia"}`))
 		Expect(created.RoutePolicy).To(Equal("prefix_cache"))
 		Expect(created.MinPrefixMatch).To(Equal(0.4))
+		Expect(schedulingJSONKeys(created)).ToNot(Or(
+			HaveKey("id"),
+			HaveKey("unsatisfiable_until"),
+			HaveKey("unsatisfiable_ticks"),
+			HaveKey("created_at"),
+			HaveKey("updated_at"),
+		))
 
 		listed, err := c.ListScheduling(ctx)
 		Expect(err).ToNot(HaveOccurred())
@@ -193,3 +201,15 @@ var _ = Describe("inproc.Client model scheduling", func() {
 		Expect(missing).To(BeNil())
 	})
 })
+
+func schedulingJSONKeys(config *localaitools.ModelSchedulingConfig) map[string]any {
+	var out map[string]any
+	Expect(json.Unmarshal([]byte(mustMarshal(config)), &out)).To(Succeed())
+	return out
+}
+
+func mustMarshal(v any) string {
+	b, err := json.Marshal(v)
+	Expect(err).ToNot(HaveOccurred())
+	return string(b)
+}

pkg/mcp/localaitools/scheduling.go

@@ -4,7 +4,6 @@ import "github.com/mudler/LocalAI/core/services/nodes"
 
 func SchedulingConfigFromNode(config nodes.ModelSchedulingConfig) ModelSchedulingConfig {
 	return ModelSchedulingConfig{
-		ID:                  config.ID,
 		ModelName:           config.ModelName,
 		NodeSelector:        config.NodeSelector,
 		MinReplicas:         config.MinReplicas,
@@ -14,10 +13,6 @@ func SchedulingConfigFromNode(config nodes.ModelSchedulingConfig) ModelSchedulin
 		BalanceAbsThreshold: config.BalanceAbsThreshold,
 		BalanceRelThreshold: config.BalanceRelThreshold,
 		MinPrefixMatch:      config.MinPrefixMatch,
-		UnsatisfiableUntil:  config.UnsatisfiableUntil,
-		UnsatisfiableTicks:  config.UnsatisfiableTicks,
-		CreatedAt:           config.CreatedAt,
-		UpdatedAt:           config.UpdatedAt,
 	}
 }