chore: ⬆️ Update CrispStrobe/CrispASR to 5fca47ecf05cd68bb0075f8a00fe04da06f208d0#10963
Merged
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
localai-bot
force-pushed
the
update/CRISPASR_VERSION
branch
from
July 19, 2026 20:20
bab70a7 to
d9763d5
Compare
The latest upstream commit contains an undeclared CrispASR gitlink that makes a blanket recursive submodule update fail. Limit initialization to the two submodules used by the backend build. Assisted-by: Codex:gpt-5 [Codex]
Collaborator
|
Pushed 744b5f2 with both fixes exposed by the matrix.
Local verification: a fresh checkout initializes both declared submodules at their pinned SHAs, skips the malformed gitlink, and rewrites the c2pa/WebRTC paths to PROJECT_SOURCE_DIR. A full local library build could not run because this host has no cmake; the restarted CI Docker matrix is the authoritative compile verification. DCO remains expectedly ACTION_REQUIRED: repository policy forbids an AI agent from adding a human Signed-off-by attestation. @mudler, please review and handle that legal gate if the technical checks finish green. |
CrispASR now builds a vendored WebRTC VAD, but its include paths assume CrispASR is the top-level CMake project. Extend the existing embedded-project rewrite to the shared third_party root. Assisted-by: Codex:gpt-5 [Codex]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: https://github.com/CrispStrobe/CrispASR/compare/1e6f3ad962dc46d86422c3baa4f3c1110d037e4d..5fca47ecf05cd68bb0075f8a00fe04da06f208d0