fix(chat): do not retry if we had chatdeltas or tooldeltas from backend#9244
Merged
fix(chat): do not retry if we had chatdeltas or tooldeltas from backend#9244
Conversation
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
8966fa6 to
8c43fd6
Compare
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
8c43fd6 to
313b5b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a critical bug in the retry logic for chat completions involving the C++ autoparser, ensuring that valid tool calls and content delivered via ChatDeltas are not discarded or retried unnecessarily. It introduces new regression tests, updates the backend mock to simulate autoparser behavior, and enhances the retry logic to properly recognize actionable ChatDelta content. This prevents excessive retries and output concatenation, improving both streaming and non-streaming chat endpoint behavior.
Bug fix: Retry logic for autoparser ChatDeltas
Testing: Regression tests for autoparser scenarios
Test infrastructure: Mock backend improvements
Test utilities
encoding/json) to support new test logic for parsing streaming responses.Notes for Reviewers
Signed commits