Skip to content

Pull request for issue #19 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
Closed

Pull request for issue #19 #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion popup/popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,11 @@ document
"{{platform.os}}": platformInfo.os || "unknown",
"{{platform.version}}": platformInfo.version,
"{{triggeredAt}}": new Date().toISOString(),
"{{identifier}}": webhook.identifier || ""
"{{identifier}}": webhook.identifier || "",
"{{currentUnixTimestamp}}": Math.floor(Date.now() / 1000),
"{{currentUnixTimestampMiliseconds}}": Date.now(),
"{{currentIsoDate}}": new Date().toISOString().slice(0, 10),
"{{currentIsoDateTime}}": new Date().toISOString(),
};
Comment on lines +178 to 181

@github-actions github-actions Bot Aug 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low: For efficiency and consistency, it's better to avoid multiple calls to Date.now() and new Date(). You can get the timestamp and ISO string once and reuse them.

A more efficient way to write this would be to declare now and isoNow variables before the placeholders object.

const now = Date.now();
const isoNow = new Date(now).toISOString();
//...
"{{currentUnixTimestamp}}": Math.floor(now / 1000),
"{{currentUnixTimestampMiliseconds}}": now,
"{{currentIsoDate}}": isoNow.slice(0, 10),
"{{currentIsoDateTime}}": isoNow,

This would require refactoring the surrounding code slightly, but would improve performance and make the code cleaner.


// Replace placeholders in custom payload
Expand Down
Loading