[combobox] Combobox.Value should render a span

[mirka]

Feature request

Summary

Select.Value and Combobox.Value both take a placeholder prop, but only Select.Value gets a data-placeholder attribute because it renders a span. Combobox.Value cannot have that attribute because it doesn't render an HTML element.

It would be convenient if both components rendered a span and received the same data-placeholder attribute.

Motivation

Selects and comboboxes are often styled similarly, and this is a place where it's good to share styles between the two. Currently, we have to look at the data-placeholder prop on the Trigger to style the placeholder Value, if we want the same style to work in both Select and Combobox.

[atomiks]

Combobox.Value intentionally doesn't render a wrapper element by default. Select.Value renders a span because Select’s alignItemWithTrigger positioning needs a DOM ref for the trigger value text, so it can align that rect with the selected item text in the popup.

Combobox doesn’t have that positioning behavior, and Combobox.Value is intentionally wrapperless so it can render arbitrary inline structure. In multiple mode, for example, it commonly renders several Combobox.Chips plus Combobox.Input as siblings inside Combobox.Chips; forcing a span around that would make the chip/input layout harder to style and is likely a breaking DOM change.

For placeholder styling, Combobox.Trigger and Combobox.InputGroup already expose data-placeholder, so I think styling from that parent state is the right approach here rather than making Combobox.Value render an element.

[mirka]

Understood, thanks for the explanation!