[combobox] Support keyed values with object items#4419
Closed
atomiks wants to merge 1 commit into
Closed
Conversation
atomiks
added
type: bug
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
PR: out-of-date
atomiks
force-pushed
the
codex/combobox-keyed-values
branch
from
April 30, 2026 05:37
192437e to
0d2f63c
Compare
github-actions
Bot
removed
the
PR: out-of-date
atomiks
marked this pull request as ready for review
April 30, 2026 05:37
atomiks
requested review from
LukasTy,
colmtuite,
flaviendelangle and
michaldudak
as code owners
April 30, 2026 05:37
Bundle size
PerformanceTotal duration: 1,501.59 ms +19.38 ms(+1.3%) | Renders: 53 (+0) | Paint: 2,292.40 ms +26.13 ms(+1.2%)
…and 7 more — details Check out the code infra dashboard for more information about this PR. |
This was referenced Jun 9, 2026
Contributor
Author
|
Replacing with #4985 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3865
Stricter alternative to #4097 without a new prop
This makes the implicit keyed combobox path predictable when
itemsuse the{ value, label }shape and the selected value is the primitiveitem.value.It keeps the supported keyed path consistent across display, selection, comparison, and docs, while tightening TypeScript so unsupported object-item shapes fail earlier instead of drifting at runtime.
Changes
{ value, label }combobox items without introducing a new prop.