-
-
Notifications
You must be signed in to change notification settings - Fork 428
[docs] Paper Mono #4437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[docs] Paper Mono #4437
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
476963c
Replace mono fonts
vladmoroz ffbeae3
Preload font
aarongarciah 77022ac
Adjust wght
aarongarciah 7331c4d
Tweak spacing
vladmoroz db55a35
Merge branch 'master' into paper-mono
vladmoroz b645915
Merge branch 'master' into paper-mono
vladmoroz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we still need this? With this, the vertical alignment seems to be a bit off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd absolutely keep it personally
When zooming in like this, yeah, its obvious that the letters are different height, but when looking at actual paragraphs I think monospace fonts stand out as way larger and overpowering. Visually it looks more balanced to me when the monospace is downsized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the vertical alignment inside paragraphs what puts me off. It doesn't happen with the current mono font or Söhne Mono.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit hacky, but adding
vertical-align: 0.02emto inline code tags seems to align them properly. @vladmoroz any better ideas on how to solve the alignment?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing the same with the current font where the x-height is about 0.5px smaller:
But overall don't think it's a problem,
vertical-align: 0.02emmakes the baseline misaligned which sticks out much more to me.It's always tough to balance monospace and sans-serif fonts when used together inline, have never seen it work perfectly. The monospace is either much wider than sans-serif, or has to be condensed as hell, becoming unreadable. That's why I prefer to bring down the size of the monospace via
size-adjustto make the width difference acceptable