[docs]: Improve controlled detached triggers demo in popover docs#4829
Open
tomasbirbe wants to merge 1 commit into
Open
[docs]: Improve controlled detached triggers demo in popover docs#4829tomasbirbe wants to merge 1 commit into
tomasbirbe wants to merge 1 commit into
Conversation
tomasbirbe
requested review from
atomiks,
colmtuite,
flaviendelangle and
michaldudak
as code owners
commit: |
Bundle size
PerformanceTotal duration: 1,103.65 ms ▼-342.26 ms(-23.7%) | Renders: 50 (+0) | Paint: 1,678.78 ms ▼-510.07 ms(-23.3%)
…and 3 more (+4 within noise) — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
PR: out-of-date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Controlled mode with multiple triggers popover demo so the detached programmatic
<button>can close the popover on a second click — the behavior called out in #4466.Clicks on that button while the popover is open are handled as an
outside-pressinonOpenChange, which can fight with the Base UI event. The demo now cancels that close when the press targets the programmatic button, then closes viaonClickinstead. Icon triggers viaPopover.Triggerkeep working as before.Docs-only; no library changes.
Changes
detached-triggers-controlled): toggleopenon the programmatic button (setOpen(false)when already open).onOpenChange: if the close reason isoutside-pressand the event target is inside the programmatic button, calleventDetails.cancel()soonClickcan close without conflicting state updates.outside-press/cancel()pattern for copy-paste from the docs.