[avatar] Fix image status edge cases#4835
Draft
atomiks wants to merge 1 commit into
Draft
Conversation
atomiks
added
type: bug
commit: |
Bundle size
PerformanceTotal duration: 1,486.29 ms +40.38 ms(+2.8%) | Renders: 50 (+0) | Paint: 2,254.92 ms +66.08 ms(+3.0%) No significant changes — details Check out the code infra dashboard for more information about this PR. |
atomiks
force-pushed
the
codex/avatar-behavior-coverage
branch
from
6259b46 to
28a5958
Compare
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the Codex component behavior and test coverage sweep. It fixes Avatar behavior/API issues found during review and adds focused regression coverage for the affected paths.
Root cause
Avatar had edge cases where its implementation and tests did not fully cover the expected image loading, fallback, and native image prop contract.
Changes
crossOrigin,referrerPolicy,srcSet, andsizes.Avatar.Imageunmounts so fallback can render again.Avatar.Fallbackdelay changes.Original findings addressed
Avatar.ImagedropscrossOriginandreferrerPolicyfrom the rendered<img>.srcSet/sizesare part of the native image API but loading status only looks atsrc.Avatar.Imagecan leave fallback hidden forever.Fallback.delayis one-shot state and does not reconcile prop changes.