[navigation menu] Preserve exit transition when controlled#4855
Open
mattrothenberg wants to merge 4 commits into
Open
[navigation menu] Preserve exit transition when controlled#4855mattrothenberg wants to merge 4 commits into
mattrothenberg wants to merge 4 commits into
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,317.26 ms 🔺+243.57 ms(+22.7%) | Renders: 50 (+0) | Paint: 1,994.30 ms 🔺+339.48 ms(+20.5%)
…and 3 more (+4 within noise) — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
275b900 to
aeeeb71
Compare
aeeeb71 to
e8efc77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When NavigationMenu is controlled, consumers can close it by updating
valuetonulldirectly. That prop-driven close does not go through the same internalsetValue(null, eventDetails)path used by interactions like hover-out, so the popup dimensions may be measured after active content has already started unmounting. In that case the popup can collapse immediately, making thedata-ending-styleexit transition appear to be skipped.Reproduction
Working
https://stackblitz.com/edit/vitejs-vite-czwevbev?file=src%2FApp.tsx
Solution
nullwhile the popup exitsTesting
pnpm vitest run packages/react/src/navigation-menu/root/NavigationMenuRoot.test.tsx --project @base-ui/reactpnpm --filter docs typescript/react/components/navigation-menu: unchecking "Menu open" appliesdata-ending-stylewith frozen popup dimensions