[docs][autocomplete] Add persistent search icon to command palette demo#5245
Merged
aarongarciah merged 6 commits intoJul 21, 2026
Merged
Conversation
mmaxence
requested review from
aarongarciah,
atomiks,
colmtuite,
flaviendelangle and
michaldudak
as code owners
July 16, 2026 01:11
commit: |
Bundle size
PerformanceTotal duration: 1,463.22 ms 🔺+247.79 ms(+20.4%) | Renders: 78 (+0) | Paint: 2,272.50 ms 🔺+381.87 ms(+20.2%)
…and 4 more (+6 within noise) — details Metric alarms
…and 8 more metric alarms — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aarongarciah
added
docs
aarongarciah
changed the title
aarongarciah
left a comment
aarongarciah
left a comment
Member
There was a problem hiding this comment.
Thanks for working on this @mmaxence. I left inline comments on a few things we need to fix before merging.
Contributor
Author
|
Applied all four: swapped the wrapper to |
Matches the cursor: text pattern used by the combobox multiple, async-multiple, and creatable InputGroup demos: pressing anywhere in the group focuses the input, so the icon and padding area should show the I-beam affordance. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Matches the inline svg icon convention used across demos. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4183
The command palette input is labelled by its placeholder only, which disappears on type. This adds a persistent search icon to the input, as agreed in the issue. Both demo variants updated.
The icon is aria-hidden and the input keeps its aria-label. Its colour matches the placeholder grey, above 3:1 contrast in light and dark. The focus outline moves to the input row so icon and input read as one field. Scoped to the icon only, none of the highlight styling from #4236.