Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions packages/utils/src/usePreviousValue.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,56 @@ describe('usePrevious', () => {
expect(previousValue).toBe(true);
});

it('should treat NaN as unchanged', () => {
let previousValue: any;
const { setProps } = render(
<TestComponent value={Number.NaN}>
{(previous) => {
previousValue = previous;
return null;
}}
</TestComponent>,
);

expect(previousValue).toBe(null);

setProps({ value: Number.NaN, unrelatedProp: 1 });
expect(previousValue).toBe(null);
});

it('should return the previous value when changing to NaN', () => {
let previousValue: any;
const { setProps } = render(
<TestComponent value={1}>
{(previous) => {
previousValue = previous;
return null;
}}
</TestComponent>,
);

setProps({ value: Number.NaN });
expect(previousValue).toBe(1);
});

it('should distinguish positive and negative zero', () => {
let previousValue: any;
const { setProps } = render(
<TestComponent value={0}>
{(previous) => {
previousValue = previous;
return null;
}}
</TestComponent>,
);

setProps({ value: -0 });
expect(previousValue).toBe(0);

setProps({ value: 0 });
expect(previousValue).toBe(-0);
});

it('should ignore renders where the value does not change', () => {
let previousValue: any;
const { setProps } = render(
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/src/usePreviousValue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export function usePreviousValue<T>(value: T): T | null {
previous: null,
});

if (value !== state.current) {
if (!Object.is(value, state.current)) {
setState({ current: value, previous: state.current });
}

Expand Down
Loading