[combobox][select] Fix hovered item stealing highlight when the list scrolls in Safari#5265
Open
arikchakma wants to merge 1 commit into
Open
Conversation
…scrolls in Safari
arikchakma
requested review from
atomiks,
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
July 18, 2026 22:43
commit: |
Bundle size
PerformanceTotal duration: 1,007.37 ms -36.99 ms(-3.5%) | Renders: 78 (+0) | Paint: 1,568.98 ms -72.74 ms(-4.4%) No significant changes — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
zannager
added
component: select
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4002
In Safari, when keyboard navigation scrolls the list, WebKit fires a
mousemoveon whatever item ends up under the cursor, even though the mouse never moved.useListNavigationtakes that as a real hover and moves the highlight there, so the keyboard highlight keeps snapping back to wherever the mouse was. Chrome and Firefox don't fire these events.The fix ignores 0 delta
mousemove/pointermoveevents when running in WebKit. Select, Combobox, and Menu all share this hook, so all three are covered.