Skip to content

[form][field][fieldset] Expand test coverage#5281

Merged
atomiks merged 1 commit into
mui:masterfrom
atomiks:codex/form-field-fieldset-100-coverage
Jul 20, 2026
Merged

[form][field][fieldset] Expand test coverage#5281
atomiks merged 1 commit into
mui:masterfrom
atomiks:codex/form-field-fieldset-100-coverage

Conversation

@atomiks

@atomiks atomiks commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Expands Form, Field, and Fieldset test coverage to 100% across statements, branches, functions, and lines on merged jsdom and Chromium results, and removes the redundant logic the sweep uncovered.

Changes

  • Added behavior tests for canceled changes, controlled dirty and touched state, label and description association, error rendering, nested disabled precedence, logical-field validation, and React 17 fallback paths.
  • Reused the shared label registration helper for Fieldset.Legend.
  • Removed redundant Field.Item parent-checkbox control id plumbing, Field.Error empty fallbacks, and unreachable nullable hidden-input registration paths.

@atomiks atomiks added component: field Changes related to the field component. component: fieldset component: form Changes related to the form component. test labels Jul 20, 2026 — with ChatGPT Codex Connector
@pkg-pr-new

pkg-pr-new Bot commented Jul 20, 2026

Copy link
Copy Markdown

commit: 46aaba5

@code-infra-dashboard

code-infra-dashboard Bot commented Jul 20, 2026

Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@base-ui/react ▼-117B(-0.03%) ▼-56B(-0.04%)

Details of bundle changes

Performance

Total duration: 1,352.16 ms +66.75 ms(+5.2%) | Renders: 78 (+0) | Paint: 2,124.33 ms +87.92 ms(+4.3%)

No significant changes — details


Check out the code infra dashboard for more information about this PR.

@netlify

netlify Bot commented Jul 20, 2026

Copy link
Copy Markdown

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 46aaba5
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a5de670aeb90c0008e539aa
😎 Deploy Preview https://deploy-preview-5281--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks
atomiks force-pushed the codex/form-field-fieldset-100-coverage branch from 7830287 to 46aaba5 Compare July 20, 2026 09:12
@atomiks
atomiks marked this pull request as ready for review July 20, 2026 10:50
@atomiks
atomiks merged commit 32cabb7 into mui:master Jul 20, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: field Changes related to the field component. component: fieldset component: form Changes related to the form component. test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant