[code-infra] Allow more permissive Element types#48186
Merged
JCQuintas merged 3 commits intomui:masterfrom May 6, 2026
Merged
Conversation
JCQuintas
added
type: bug
Netlify deploy previewhttps://deploy-preview-48186--material-ui.netlify.app/ Bundle size report
|
github-actions
Bot
added
the
PR: out-of-date
github-actions
Bot
removed
the
PR: out-of-date
Deploy previewhttps://deploy-preview-48186--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
Member
|
Why is it resolving to |
Janpot
reviewed
May 6, 2026
Member
Janpot
left a comment
Janpot
left a comment
There was a problem hiding this comment.
Ok, nvm, did some testing
// A — no return-type annotation
export default function Component(props: Props) {
return <div>{props.value}</div>;
}
// B — explicit annotation
export default function Component(props: Props): React.JSX.Element {
return <div>{props.value}</div>;
}checker.getFullyQualifiedName(returnType.symbol) output:
A: "/.../node_modules/.pnpm/@types+react@19.2.14/node_modules/@types/react/jsx-runtime".JSX.Element
B: React.JSX.Element
This PR is probably the best we can do atm
Janpot
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some instances in X where the resolver uses the file location as the import name, which means we need to manually say that function returns a component.
Else it resolves to
".../node_modules/@types/react/jsx-runtime".JSX.ElementIn this PR I make the resolver more permissive by only checking that the final types have the correct name.