bind the unused error binding in 5 swallow-only catch blocks#48786
Open
HrachShah wants to merge 1 commit into
Open
bind the unused error binding in 5 swallow-only catch blocks#48786HrachShah wants to merge 1 commit into
HrachShah wants to merge 1 commit into
Conversation
…torageManager.ts (localStorage.getItem / setItem: Safari private mode, iframe with cookies blocked, QuotaExceededError on a full storage area), useLocalStorageState.ts (getSnapshot / setValue: feature-detection for localStorage availability per the MDN docs), buildFormatNumber.ts (Intl.NumberFormat: RangeError on an invalid BCP 47 locale tag, TypeError if the runtime is missing ICU data), and useSlider.ts (setPointerCapture: invalid pointerId in synthetic events or already-released pointer). All five swallow the error and the bare 'catch' form meant the error object was not even bound. Binding to a leading-underscore identifier makes the deliberate-swallowing intent explicit in the syntax, leaves a hook for future telemetry that wants to log the swallowed error without changing the call site, and matches the style already used in adjacent code where the error is bound (useSlider, isFocusVisible, useIsFocusVisible all use 'catch (error) { ... }')
zannager
added
the
scope: system
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
Member
There was a problem hiding this comment.
What's the benefit of this? What does it improve?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...