[code-infra] Automate team sync on about page#48794
Conversation
|
I may have missed something about why we still have the manual sync script. So feel free to ignore if there is a specific reason for that. |
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
Not sure this is the exact reason, but historically, it tends to be prone to breakage when things change on hibob side. Checking in the file manually adds an extra level of review. And tbh, if we're going to do it at build time, I'd rather move all data fetching from code-infra to this repo. edt: a useful addition could be a check whether a photo/flag is present for the employee. This is something that has been breaking in the past when data updated in hibob. |
a2c3846 to
3daea41
Compare
I like current simplicity where code-infra handles the hard part, ie, keeping the hibob token, which it already has for a bunch of other services, so why not one more and core docs does a simple fetch.
Hmm. Photo fetching seems to be the main blocker I think for this PR. We can't reliably directly use one from hibob (even if it has one) without caching it somewhere. Also, we have to ensure there exists a pic for each each during the build. |
|
I think the main issue is that seemingly harmless changes in hibob (update someones name, country, add someone...) can break the build. It has happened before, where an accent was corrected in a name and suddenly the name of the photo doesn't match up anymore. Keeping the sync explicit contains this brittleness to a single PR. |
3daea41 to
5638c19
Compare
5638c19 to
9db91e4
Compare
|
Updated the PR to instead automate the process so we can still validate changes before merging. |
32b5e0f to
4ddd3cb
Compare
|
In this setup, does it still make sense to keep the logic in code-infra? We could keep the token in GHA secrets? |
|
Yeah. We can move that here. |
|
On a second note, moving this here then won't allow someone to create the PR manually, if that is something we still want to keep. |
b74972f to
111c447
Compare
ok, yeah. Let's wait then. |
Summary
Scheduled triggers weekly on Monday. Can be triggered manually as well from https://github.com/mui/material-ui/actions
Automatically deletes any images as well as adds a summary for people whose images are missing.