Skip to content

[code-infra] Automate team sync on about page#48794

Open
brijeshb42 wants to merge 3 commits into
mui:masterfrom
brijeshb42:docs/about-fetch-team-build-time
Open

[code-infra] Automate team sync on about page#48794
brijeshb42 wants to merge 3 commits into
mui:masterfrom
brijeshb42:docs/about-fetch-team-build-time

Conversation

@brijeshb42

@brijeshb42 brijeshb42 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Scheduled triggers weekly on Monday. Can be triggered manually as well from https://github.com/mui/material-ui/actions
Automatically deletes any images as well as adds a summary for people whose images are missing.

@brijeshb42 brijeshb42 added the docs Improvements or additions to the documentation. label Jul 9, 2026
@brijeshb42 brijeshb42 requested a review from a team July 9, 2026 08:09
@brijeshb42

Copy link
Copy Markdown
Contributor Author

I may have missed something about why we still have the manual sync script. So feel free to ignore if there is a specific reason for that.

@code-infra-dashboard

code-infra-dashboard Bot commented Jul 9, 2026

Copy link
Copy Markdown

Deploy preview

https://deploy-preview-48794--material-ui.netlify.app/
QR code for https://deploy-preview-48794--material-ui.netlify.app/

Bundle size

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/private-theming 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@Janpot

Janpot commented Jul 9, 2026

Copy link
Copy Markdown
Member

I may have missed something about why we still have the manual sync script. So feel free to ignore if there is a specific reason for that.

Not sure this is the exact reason, but historically, it tends to be prone to breakage when things change on hibob side. Checking in the file manually adds an extra level of review. And tbh, if we're going to do it at build time, I'd rather move all data fetching from code-infra to this repo.

edt: a useful addition could be a check whether a photo/flag is present for the employee. This is something that has been breaking in the past when data updated in hibob.

@brijeshb42 brijeshb42 force-pushed the docs/about-fetch-team-build-time branch from a2c3846 to 3daea41 Compare July 9, 2026 10:13
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 9, 2026
@brijeshb42

Copy link
Copy Markdown
Contributor Author

I'd rather move all data fetching from code-infra to this repo

I like current simplicity where code-infra handles the hard part, ie, keeping the hibob token, which it already has for a bunch of other services, so why not one more and core docs does a simple fetch.

check whether a photo/flag is present for the employee

Hmm. Photo fetching seems to be the main blocker I think for this PR. We can't reliably directly use one from hibob (even if it has one) without caching it somewhere. Also, we have to ensure there exists a pic for each each during the build.

@Janpot

Janpot commented Jul 9, 2026

Copy link
Copy Markdown
Member

I think the main issue is that seemingly harmless changes in hibob (update someones name, country, add someone...) can break the build. It has happened before, where an accent was corrected in a name and suddenly the name of the photo doesn't match up anymore. Keeping the sync explicit contains this brittleness to a single PR.

@brijeshb42 brijeshb42 force-pushed the docs/about-fetch-team-build-time branch from 3daea41 to 5638c19 Compare July 10, 2026 05:46
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 10, 2026
@brijeshb42 brijeshb42 changed the title [docs] Sync team members at build time instead of manual [code-infra] Automate team sync on about page Jul 10, 2026
@brijeshb42 brijeshb42 force-pushed the docs/about-fetch-team-build-time branch from 5638c19 to 9db91e4 Compare July 10, 2026 05:55
@brijeshb42

brijeshb42 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Updated the PR to instead automate the process so we can still validate changes before merging.

@brijeshb42 brijeshb42 force-pushed the docs/about-fetch-team-build-time branch 2 times, most recently from 32b5e0f to 4ddd3cb Compare July 10, 2026 06:08
@Janpot

Janpot commented Jul 10, 2026

Copy link
Copy Markdown
Member

In this setup, does it still make sense to keep the logic in code-infra? We could keep the token in GHA secrets?

@brijeshb42

Copy link
Copy Markdown
Contributor Author

Yeah. We can move that here.

@brijeshb42

Copy link
Copy Markdown
Contributor Author

On a second note, moving this here then won't allow someone to create the PR manually, if that is something we still want to keep.

@brijeshb42 brijeshb42 force-pushed the docs/about-fetch-team-build-time branch from b74972f to 111c447 Compare July 10, 2026 08:15
@brijeshb42 brijeshb42 added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Jul 10, 2026
@Janpot

Janpot commented Jul 10, 2026

Copy link
Copy Markdown
Member

On a second note, moving this here then won't allow someone to create the PR manually, if that is something we still want to keep.

ok, yeah. Let's wait then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants