Skip to content

[pickers] Fix date and time merging to retain milliseconds#14173

Merged
LukasTy merged 7 commits into
mui:masterfrom
LukasTy:fix-date-utils-date-time-merging
Aug 12, 2024
Merged

[pickers] Fix date and time merging to retain milliseconds#14173
LukasTy merged 7 commits into
mui:masterfrom
LukasTy:fix-date-utils-date-time-merging

Conversation

@LukasTy
Copy link
Copy Markdown
Member

@LukasTy LukasTy commented Aug 12, 2024

Fixes tests for some reason only failing with mui@material v6 seen in #14142.

  • The util had missing milliseconds retaining.
  • A test was incorrect and not testing anything. 🤷 🙈

@LukasTy LukasTy added type: bug It doesn't behave as expected. scope: pickers Changes related to the date/time pickers. labels Aug 12, 2024
@LukasTy LukasTy self-assigned this Aug 12, 2024
@mui-bot
Copy link
Copy Markdown

mui-bot commented Aug 12, 2024

Deploy preview: https://deploy-preview-14173--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 53abcac

@flaviendelangle
Copy link
Copy Markdown
Member

One test seems to be complaining
But other than that, the fix and the test changes make a lot of sense!

@LukasTy
Copy link
Copy Markdown
Member Author

LukasTy commented Aug 12, 2024

One test seems to be complaining
But other than that, the fix and the test changes make a lot of sense!

Yeah, it seems that the tests was relying on a "buggy" previous behavior, where milliseconds were ignored.
I've aligned the initial and expected values to avoid the error. 👍

Copy link
Copy Markdown
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it!

@LukasTy LukasTy merged commit 51ec133 into mui:master Aug 12, 2024
@LukasTy LukasTy deleted the fix-date-utils-date-time-merging branch August 12, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: pickers Changes related to the date/time pickers. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants