[code-infra] Fix changelog generator for Premium-without-Pro products#22029
Merged
Conversation
The Premium branch of `logProductSection` hard-coded a `${packageName}-pro`
reference in its "Same changes as in" line, producing a dangling
`@mui/x-scheduler-pro` entry for products like Scheduler that ship Premium
without a Pro tier. Consult `hasProVersion` and fall back to the base
package when no Pro tier exists, and fix up the existing stale line in
the v9.0.0 changelog entry.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Deploy preview: https://deploy-preview-22029--material-ui-x.netlify.app/ Bundle size report
|
arminmeh
approved these changes
Apr 8, 2026
LukasTy
added
type: enhancement
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
FYI, I already checked locally that the changes no longer generate the |
michelengelen
approved these changes
Apr 8, 2026
Member
michelengelen
left a comment
michelengelen
left a comment
There was a problem hiding this comment.
Thanks for handling this. When writing it I did not imagine we would have a Premium package without a Pro counterpart! 😅
arminmeh
pushed a commit
to arminmeh/mui-x
that referenced
this pull request
Apr 29, 2026
…mui#22029) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Premium branch of
logProductSectioninscripts/changelogUtils.mjshard-coded a${packageName}-proreference in its "Same changes as in" line. For products that ship Premium without a Pro tier (currently only Scheduler), this generated a dangling reference to a package that does not exist - e.g.@mui/x-scheduler-pro@9.0.0-alpha.0in the v9.0.0 entry (#22020,CHANGELOG.md:97).Fix: consult the already-tracked
hasProVersionflag and fall back to the base package when no Pro tier exists. Also fix up the existing stale line in the v9.0.0 changelog entry so consumers reading it today land on a real package.Changes
scripts/changelogUtils.mjs: in theif (hasPremiumVersion)block, compute apreviousTierPackageas@mui/${packageName}-prowhenhasProVersionis true, otherwise@mui/${packageName}. Use that variable in both the "...plus:" and standalone "Same changes as in" lines.CHANGELOG.md:@mui/x-scheduler-pro@9.0.0-alpha.0->@mui/x-scheduler@9.0.0-alpha.0(line 97).Test plan
@mui/x-data-grid-pro@..., unchanged.@mui/x-scheduler@...instead of the non-existent@mui/x-scheduler-pro@....grep -rn 'x-scheduler-pro' CHANGELOG.md scripts/returns no matches after the fix.Reported during review of #22020.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
🤖 Generated with Claude Code