Skip to content

Check PHP 8.3 error #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mukeshpanchal27 wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

Check PHP 8.3 error #48

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3069a6
Check PHP 8.3 error
mukeshpanchal27 Aug 13, 2024
349ae8b
Remove
mukeshpanchal27 Aug 13, 2024
d98ab3b
Update tests/phpunit/tests/html-api/wpHtmlTagProcessor.php
mukeshpanchal27 Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/phpunit/tests/html-api/wpHtmlTagProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2914,4 +2914,14 @@ public function test_unclosed_funky_comment_input_too_short() {
$this->assertFalse( $processor->next_tag() );
$this->assertTrue( $processor->paused_at_incomplete_token() );
}

public function test_next_tag_issue_for_trunk_and_php83() {
$picture_markup = '<p><img width="1024" height="683" src="http://localhost:8889/wp-content/uploads/2024/08/leaves-226-1024x683.webp" class="wp-image-4" alt="Green Leaves" decoding="async" loading="lazy" srcset="http://localhost:8889/wp-content/uploads/2024/08/leaves-226-1024x683.webp 1024w, http://localhost:8889/wp-content/uploads/2024/08/leaves-226-300x200.webp 300w, http://localhost:8889/wp-content/uploads/2024/08/leaves-226-768x512.webp 768w, http://localhost:8889/wp-content/uploads/2024/08/leaves-226-jpg.webp 1080w" sizes="(max-width: 1024px) 100vw, 1024px" /></p>';
$picture_processor = new WP_HTML_Tag_Processor( $picture_markup );
$this->assertFalse( $picture_processor->next_tag( array( 'tag_name' => 'PICTURE' ) ), 'There should not be a PICTURE tag.' );

$picture_processor = new WP_HTML_Tag_Processor( $picture_markup );
$picture_processor->next_tag( array( 'tag_name' => 'IMG' ) );
$this->assertStringEndsWith( '.webp', $picture_processor->get_attribute( 'src' ), 'Make sure the IMG should return WEBP src.' );
}
}