Skip to content

Commit fb2d9dc

Browse files
committed
* python/doc/source/benchmarks.inc.rst: dmosopt uses moocore now.
* python/benchmarks/bench_hv.py: Update. * python/benchmarks/bench_ndsort.py: Update.
1 parent 7a726e5 commit fb2d9dc

3 files changed

Lines changed: 1 addition & 12 deletions

File tree

python/benchmarks/bench_hv.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@
3131
## https://github.com/secondmind-labs/trieste/issues/917
3232
# from trieste.acquisition.multi_objective import Pareto as trieste_Pareto
3333
# import tensorflow as tf
34-
## dmosopt is too slow to benchmark
35-
## https://github.com/dmosopt/dmosopt/issues/119
36-
# from dmosopt.hv_box_decomposition import compute_hypervolume_box_decomposition
3734

3835
from moarchiving import get_mo_archive as moarch_get_mo_archive
3936

@@ -93,7 +90,6 @@
9390
"fast_pareto": lambda z, ref=ref: fp_hv(
9491
z, ref_point=ref, assume_pareto=False
9592
),
96-
# "dmosopt": lambda z, ref=ref: compute_hypervolume_box_decomposition(z, ref_point=ref),
9793
}
9894
# Too slow to run.
9995
if dim >= 6:

python/benchmarks/bench_ndsort.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@
2020
from paretoset import paretorank as paretoset_paretorank
2121
## It cannot be installed: https://github.com/esa/pygmo2/issues/152
2222
# from pygmo import pareto_dominance as pg_pareto_dominance
23-
## dmosopt is 100-1000x slower, i.e., too slow.
24-
# from dmosopt.dda import dda_ens as dmosopt_paretorank
2523

2624
files = {
2725
# range are the (start, stop, num) parameters for np.geomspace()
@@ -61,7 +59,6 @@ def get_dataset(name):
6159
"paretoset": lambda z: paretoset_paretorank(z, use_numba=True) - 1,
6260
"pymoo": lambda z, nds=pymoo_NDS(): nds.do(z, return_rank=True)[1],
6361
"desdeo": lambda z: desdeo_nds(z).argmax(axis=0),
64-
# "dmosopt": lambda z: dmosopt_paretorank(z),
6562
},
6663
check=check_array_equal,
6764
)

python/doc/source/benchmarks.inc.rst

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,7 @@ include `paretobench`_ because it is always slower than `BoTorch`_ for
1414
identifying nondominated points and more than 2000 times slower than `moocore`_
1515
for computing the hypervolume in 3D
1616
(https://github.com/electronsandstuff/ParetoBench/issues/57), which is too slow
17-
to include in the benchmarks. Nondominated sorting and hypervolume computation
18-
in `dmosopt`_ are 100-1000 times lower than the equivalent functions in
19-
`moocore`_ even in 3D (See https://github.com/dmosopt/dmosopt/issues/118 and
20-
https://github.com/dmosopt/dmosopt/issues/119), which is too slow to include in
21-
the benchmarks.
17+
to include in the benchmarks.
2218

2319
Not all packages provide the same functionality. For example, `pymoo`_ does not
2420
provide the :ref:`epsilon indicator <epsilon_metric>`. `BoTorch`_ and

0 commit comments

Comments
 (0)