Skip to content

Commit c3f2179

Browse files
committed
fix hash function lookups
1 parent 6329ced commit c3f2179

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

src/test/java/io/ipfs/multihash/MultihashTest.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,19 @@ public void base58Test() {
2323
public void multihashTest() {
2424
Object[][] examples = new Object[][]{
2525
{Multihash.Type.sha1, "SHA-1", "5drNu81uhrFLRiS4bxWgAkpydaLUPW", "hello world"},
26-
{Multihash.Type.sha2_256, "SHA2-256", "QmaozNR7DZHQK1ZcU9p7QdrshMvXqWK6gpu5rmrkPdT3L4", "hello world"},
27-
{Multihash.Type.sha2_512, "SHA2-512", "8Vtkv2tdQ43bNGdWN9vNx9GVS9wrbXHk4ZW8kmucPmaYJwwedXir52kti9wJhcik4HehyqgLrQ1hBuirviLhxgRBNv", "hello world"},
28-
{Multihash.Type.sha3_512, "SHA3-512", "8tWhXW5oUwtPd9d3FnjuLP1NozN3vc45rmsoWEEfrZL1L6gi9dqi1YkZu5iHb2HJ8WbZaaKAyNWWRAa8yaxMkGKJmX", "hello world"},
26+
{Multihash.Type.sha2_256, "SHA-256", "QmaozNR7DZHQK1ZcU9p7QdrshMvXqWK6gpu5rmrkPdT3L4", "hello world"},
27+
{Multihash.Type.sha2_512, "SHA-512", "8Vtkv2tdQ43bNGdWN9vNx9GVS9wrbXHk4ZW8kmucPmaYJwwedXir52kti9wJhcik4HehyqgLrQ1hBuirviLhxgRBNv", "hello world"}
28+
// SHA3 not yet implemented in standard Java library. https://docs.oracle.com/javase/7/docs/technotes/guides/security/StandardNames.html#MessageDigest
29+
// {Multihash.Type.sha3_512, "SHA3-512", "8tWhXW5oUwtPd9d3FnjuLP1NozN3vc45rmsoWEEfrZL1L6gi9dqi1YkZu5iHb2HJ8WbZaaKAyNWWRAa8yaxMkGKJmX", "hello world"}
2930
};
3031

3132
for(Object[] ex: examples) {
3233
Multihash m = Multihash.fromBase58((String)ex[2]);
3334
try {
34-
// Make sure the hashes agree
35-
MessageDigest md = MessageDigest.getInstance((String) ex[3]);
35+
MessageDigest md = MessageDigest.getInstance((String) ex[1]);
36+
assert(md != null);
3637
md.update(((String) ex[3]).getBytes("UTF-8"));
3738
byte[] digest = md.digest();
38-
assert(Arrays.equals(m.toBytes(), digest));
3939
// Test constructor
4040
Multihash m2 = new Multihash((Multihash.Type)ex[0], digest);
4141
// Test comparison
@@ -45,6 +45,9 @@ public void multihashTest() {
4545
assert(m.toBase58().equals((String)ex[2]));
4646
}
4747
catch (Exception e){
48+
// Usually because a hash function not supported
49+
System.out.println(e.getMessage());
50+
assert(false);
4851
}
4952
}
5053
}

0 commit comments

Comments
 (0)