fix: correct decapsulate for repeated protocols and substring collisions#124
Open
sumanjeet0012 wants to merge 1 commit into
Open
fix: correct decapsulate for repeated protocols and substring collisions#124sumanjeet0012 wants to merge 1 commit into
sumanjeet0012 wants to merge 1 commit into
Conversation
sumanjeet0012
changed the title
sumanjeet0012
force-pushed
the
fix-issue-109
branch
from
d6d2f2c to
84e2179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109
Description
This pull request fixes a bug where
Multiaddr.decapsulate()produced incorrect results when the same protocol appears multiple times in the address, or when the decapsulation target is a substring of a protocol value. The implementation has been updated to compare addresses component-by-component usingbytes_iter()instead of performing a raw string search.Changes
Multiaddr.decapsulateinmultiaddr/multiaddr.pyto match components iteratively instead of usingstr.rindex().tests/test_multiaddr.pycontaining edge cases for:newsfragments/109.bugfix.