fix: validate binary input in _from_bytes()#125
Open
sumanjeet0012 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110
Description
This pull request adds strict validation to the binary multiaddr parser. It updates
_from_bytes()to parse components iteratively usingbytes_iter(), ensuring invalid bytes are rejected immediately upon initialization rather than failing later during conversion. It also updatesbytes_iter()to catch truncated streams.Changes
Multiaddr._from_bytes()to validate raw binary components fully and raise aBinaryParseErrorupon encountering unexpected bytes.bytes_iter()to raise aBinaryParseErrorif a component's byte length is shorter than expected.test_invalid_bytes()totests/test_multiaddr.pyto test various invalid multiaddr byte strings.newsfragments/110.bugfix.