fix: handle path protocols correctly in string_iter()#126
Open
sumanjeet0012 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112
Description
This pull request ensures that
string_iter()inmultiaddr/transforms.pyhas the same handling for path protocols (e.g.,unix) asMultiaddr._from_string(). Previously, it was only taking a single chunk of string as the protocol's value, which fails for paths containing multiple slashes (e.g.,/unix/var/run/docker.sock). This update explicitly checks if a codec is a path (codec.IS_PATH) and if so, consumes all remaining components joined by slashes.Changes
string_iter()inmultiaddr/transforms.pyto usegetattr(codec, \IS_PATH\, False)to check for path codecs and consume remaining parts appropriately.test_string_iter_unix_path()intests/test_transforms.pyto explicitly verify the behavior of parsing a/unix/path string.newsfragments/112.bugfix.