Correct error

Author: johnsamuelwrites

multilingualprogramming/codegen/ui_lowering.py

@@ -7,6 +7,7 @@
 """Lower reactive Core IR into a self-contained HTML/JavaScript preview."""
 
 # pylint: disable=too-many-return-statements,too-many-branches
+# pylint: disable=too-many-instance-attributes,too-many-locals,too-many-statements
 
 from __future__ import annotations
 
@@ -125,7 +126,11 @@ def __init__(self) -> None:
         self._ui_function_names: set[str] = set()
         self._render_function = ""
 
-    def lower(self, program: IRProgram, modules: dict[str, IRProgram] | None = None) -> UILoweringResult:
+    def lower(
+        self,
+        program: IRProgram,
+        modules: dict[str, IRProgram] | None = None,
+    ) -> UILoweringResult:
         """Lower an IRProgram to UI output."""
         preamble = self._emit_preamble()
         self._lower_imported_modules(modules or {})
@@ -208,12 +213,24 @@ def _lower_node(self, node: IRNode) -> None:
             self._lower_render_block(node)
             return
         if isinstance(node, IRFunction):
+            if self._is_ui_entry_function(node):
+                self._ui_function_names.add(node.name)
+                for child in node.body:
+                    self._lower_node(child)
+                return
             self._lower_function(node)
             if not node.is_async:
                 self._ui_function_names.add(node.name)
                 for child in node.body:
                     self._lower_node(child)
 
+    def _is_ui_entry_function(self, node: IRFunction) -> bool:
+        """Return True for functions that serve as reactive UI entry containers."""
+        effects = getattr(node, "effects", None)
+        if effects is None or not hasattr(effects, "names"):
+            return False
+        return "ui" in effects.names()
+
     def _emit_preamble(self) -> str:
         return """// Generated by Multilingual UI lowering
 class ReactiveSignal {
@@ -832,8 +849,16 @@ def _expr_to_js(self, node: IRNode | None) -> str:
             return node.name
         if isinstance(node, IRIndexAccess):
             if isinstance(node.index, IRSliceExpr):
-                start = self._expr_to_js(node.index.start) if node.index.start is not None else "undefined"
-                stop = self._expr_to_js(node.index.stop) if node.index.stop is not None else "undefined"
+                start = (
+                    self._expr_to_js(node.index.start)
+                    if node.index.start is not None
+                    else "undefined"
+                )
+                stop = (
+                    self._expr_to_js(node.index.stop)
+                    if node.index.stop is not None
+                    else "undefined"
+                )
                 return f"{self._expr_to_js(node.obj)}.slice({start}, {stop})"
             return f"{self._expr_to_js(node.obj)}[{self._expr_to_js(node.index)}]"
         if isinstance(node, IRSliceExpr):
@@ -946,6 +971,9 @@ def _call_name(self, node: IRNode | None) -> str | None:
         return None
 
 
-def lower_to_ui(program: IRProgram, modules: dict[str, IRProgram] | None = None) -> UILoweringResult:
+def lower_to_ui(
+    program: IRProgram,
+    modules: dict[str, IRProgram] | None = None,
+) -> UILoweringResult:
     """Lower an IRProgram to a browser preview bundle."""
     return UILoweringPass().lower(program, modules=modules)

tests/core1/test_ui_output_validation.py

@@ -92,6 +92,14 @@ def test_memory_game_js_no_undefined_calls():
     assert "class undefined" not in js
 
 
+def test_memory_game_js_has_no_unsupported_placeholders():
+    """Generated JS should not include unsupported placeholder comments."""
+    ui_result = _load_memory_game_ui()
+    js = ui_result.emit_js()
+
+    assert "unsupported" not in js
+
+
 def test_memory_game_js_has_render_initialization():
     """Generated JS initializes render on page load."""
     ui_result = _load_memory_game_ui()