Skip to content

Commit a960855

Browse files
authored
Update comment even if all approved (#55)
1 parent 6907288 commit a960855

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

internal/app/app.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ func (a *App) processApprovalsAndReviewers() (bool, string, []string, error) {
294294
func (a *App) addReviewStatusComment(allRequiredOwners codeowners.ReviewerGroups, maxReviewsMet bool) error {
295295
// Comment on the PR with the codeowner teams required for review
296296

297-
if a.config.Quiet || len(allRequiredOwners) == 0 {
297+
if a.config.Quiet {
298298
a.printDebug("Skipping review status comment (disabled or no unapproved owners).\n")
299299
return nil
300300
}
@@ -334,7 +334,7 @@ func (a *App) addReviewStatusComment(allRequiredOwners codeowners.ReviewerGroups
334334
if err != nil {
335335
return fmt.Errorf("UpdateComment Error: %v", err)
336336
}
337-
} else {
337+
} else if len(allRequiredOwners) > 0 {
338338
a.printDebug("Adding new review status comment: %q\n", comment)
339339
err = a.client.AddComment(comment)
340340
if err != nil {

0 commit comments

Comments
 (0)